Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use failure rather than cancelled or timed_out conclusions #250

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

jglick
Copy link
Member

@jglick jglick commented Mar 4, 2022

@jglick jglick requested a review from a team as a code owner March 4, 2022 16:04
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #250 (f9d423e) into master (d93ac64) will increase coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #250      +/-   ##
============================================
+ Coverage     80.49%   80.79%   +0.30%     
  Complexity      170      170              
============================================
  Files            16       16              
  Lines           528      526       -2     
  Branches         49       49              
============================================
  Hits            425      425              
+ Misses           81       79       -2     
  Partials         22       22              
Impacted Files Coverage Δ
...ins/plugins/checks/github/GitHubChecksDetails.java 78.02% <ø> (+1.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d93ac64...f9d423e. Read the comment docs.

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds right, but I have no familiarity with this plugin.

@jglick
Copy link
Member Author

jglick commented Mar 4, 2022

I do not have much either, except to the extent that I wrote a similar plugin for CloudBees CI.

@timja timja added the enhancement New feature or request label Mar 4, 2022
@timja timja merged commit 09a1d39 into jenkinsci:master Mar 4, 2022
@jglick jglick deleted the patch-1 branch March 4, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants