Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable integration tests #332

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

timja
Copy link
Member

@timja timja commented Apr 19, 2023

Fixes #329

see #307

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #332 (d1d58cb) into master (eb574b3) will increase coverage by 21.67%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master     #332       +/-   ##
=============================================
+ Coverage     50.38%   72.05%   +21.67%     
- Complexity      114      162       +48     
=============================================
  Files            16       16               
  Lines           526      526               
  Branches         49       49               
=============================================
+ Hits            265      379      +114     
+ Misses          246      123      -123     
- Partials         15       24        +9     

see 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@timja timja force-pushed the re-enable-tests branch 2 times, most recently from fe75080 to 2a44a37 Compare April 19, 2023 13:45
@timja timja marked this pull request as ready for review April 19, 2023 13:47
@timja timja requested a review from a team as a code owner April 19, 2023 13:47
@timja timja added the tests label Apr 19, 2023
@timja
Copy link
Member Author

timja commented Apr 19, 2023

fyi @jglick

Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be much simpler to review if not all tests were deleted a couple of hours before. But anyway, thanks for fixing so fast...

@timja timja merged commit 4e4c250 into jenkinsci:master Apr 19, 2023
@timja timja deleted the re-enable-tests branch April 19, 2023 16:09
@jglick
Copy link
Member

jglick commented Apr 19, 2023

Aggregate diff, with some other stuff mixed in: f4c1127...4e4c250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable integrations tests
3 participants