Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GithubSecurityRealm.java for consistency in URL building. #118

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update GithubSecurityRealm.java for consistency in URL building. #118

wants to merge 3 commits into from

Commits on Feb 2, 2020

  1. Update GithubSecurityRealm.java for consistency in URL building. 

    There is an open PR to facilitate configuration of redirect_uri but it appears to me that it only hit one of the 2 places that the uri needed to be appended. I am modifying the code for hygiene to make it more obvious where to slip that in (and perhaps also slip in allow_signup).
    @johnclyde
    johnclyde committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    93f9d06 View commit details
    Browse the repository at this point in the history

  2. Update GithubSecurityRealm.java

    @johnclyde
    johnclyde committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    7a230bf View commit details
    Browse the repository at this point in the history

  3. Update GithubSecurityRealm.java

    @johnclyde
    johnclyde committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    e4437f8 View commit details
    Browse the repository at this point in the history