Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking: Limit permissions (optionally) to collaborators when triggering builds #46

Merged
merged 8 commits into from
Jul 18, 2022
Merged

Breaking: Limit permissions (optionally) to collaborators when triggering builds #46

merged 8 commits into from
Jul 18, 2022

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented Jul 4, 2022

Fixes #42

  • [ X] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [X ] Ensure that the pull request title represents the desired changelog entry
  • [X ] Please describe what you did
  • [ X] Link to relevant issues in GitHub or Jira
  • [ X] Link to relevant pull requests, esp. upstream and downstream changes
  • [X ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

@lprimak lprimak marked this pull request as ready for review July 4, 2022 20:43
@lprimak lprimak marked this pull request as draft July 5, 2022 23:26
@lprimak lprimak marked this pull request as ready for review July 5, 2022 23:38
@lprimak
Copy link
Contributor Author

lprimak commented Jul 12, 2022

@bluesliverx this is ready to be merged... please look at it.
thank you!

@lprimak
Copy link
Contributor Author

lprimak commented Jul 17, 2022

@jetersen any chance merging this in please? thank you!

@bluesliverx
Copy link
Contributor

My apologies, @lprimak, I've been on vacation for the last couple of weeks, and just got back. I can take a look, but it might be tomorrow before I can really look into it. Sorry for the delay, but thank you for the contribution!

bluesliverx
bluesliverx reviewed Jul 17, 2022
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@bluesliverx
Copy link
Contributor

@lprimak, I got a minute to review it today. Thanks so much for the contribution as this has been requested multiple times! The biggest things are the new dependency and maintaining backwards compatibility. I'm open to discussion as well.

@lprimak
Copy link
Contributor Author

lprimak commented Jul 18, 2022

thanks @bluesliverx

@lprimak
Copy link
Contributor Author

lprimak commented Jul 18, 2022

email sent

@lprimak
Copy link
Contributor Author

lprimak commented Jul 18, 2022

I guess the only thing to do is to change README

@lprimak lprimak changed the title Limit permissions (optionally) to collaborators when triggering builds Breaking: Limit permissions (optionally) to collaborators when triggering builds Jul 18, 2022
jetersen
jetersen reviewed Jul 18, 2022
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
jetersen
jetersen suggested changes Jul 18, 2022
View reviewed changes
Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your breaking binary compatibility and potentially breaking JobDSL or groovy scripts.

src/main/java/com/adobe/jenkins/github_pr_comment_build/TriggerPRCommentBranchProperty.java Outdated Show resolved Hide resolved
src/main/java/com/adobe/jenkins/github_pr_comment_build/TriggerPRReviewBranchProperty.java Outdated Show resolved Hide resolved
src/main/java/com/adobe/jenkins/github_pr_comment_build/TriggerPRUpdateBranchProperty.java Outdated Show resolved Hide resolved
@lprimak
Copy link
Contributor Author

lprimak commented Jul 18, 2022

should be all set now

jetersen
jetersen approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bluesliverx
Copy link
Contributor

Nitpicking things now obviously, just that casing change. And if you don't want to do it, I can take care of it after this merges, just let me know.

@lprimak lprimak requested a review from bluesliverx July 18, 2022 20:37
@bluesliverx bluesliverx merged commit 2dcf62b into jenkinsci:master Jul 18, 2022
Unpublished pushed a commit to Unpublished/jenkins-job-builder that referenced this pull request May 6, 2023
@iwane-pl
New permissions option for GitHub PR Comment Build plugin
5cea04a 
In version 78.v2dcf62ba199b GitHub Pull Request Comment Build Plugin
introduced permissions check for users triggering jobs with comments.
This added a new checkbox/XML element that allows untrusted users to
trigger builds.
(see jenkinsci/github-pr-comment-build-plugin#46)

This commit adds support for this option by allowing dictionary syntax for GH PR Comment Build plugin:
 ```
 - trigger-build-on-pr-review:
    allow-untrusted-users: true
 ```
 while preserving support for currently existing syntax:
 ```
 - trigger-build-on-pr-review: true
 ```

Change-Id: I554129c779161b47cba4566f7821ef7590a242e0
mika pushed a commit to sipwise/jenkins-job-builder that referenced this pull request Apr 29, 2024
@iwane-pl
New permissions option for GitHub PR Comment Build plugin
e38b4ce 
In version 78.v2dcf62ba199b GitHub Pull Request Comment Build Plugin
introduced permissions check for users triggering jobs with comments.
This added a new checkbox/XML element that allows untrusted users to
trigger builds.
(see jenkinsci/github-pr-comment-build-plugin#46)

This commit adds support for this option by allowing dictionary syntax for GH PR Comment Build plugin:
 ```
 - trigger-build-on-pr-review:
    allow-untrusted-users: true
 ```
 while preserving support for currently existing syntax:
 ```
 - trigger-build-on-pr-review: true
 ```

Change-Id: I554129c779161b47cba4566f7821ef7590a242e0
mika pushed a commit to sipwise/jenkins-job-builder that referenced this pull request Apr 29, 2024
@iwane-pl
New permissions option for GitHub PR Comment Build plugin
da55990 
In version 78.v2dcf62ba199b GitHub Pull Request Comment Build Plugin
introduced permissions check for users triggering jobs with comments.
This added a new checkbox/XML element that allows untrusted users to
trigger builds.
(see jenkinsci/github-pr-comment-build-plugin#46)

This commit adds support for this option by allowing dictionary syntax for GH PR Comment Build plugin:
 ```
 - trigger-build-on-pr-review:
    allow-untrusted-users: true
 ```
 while preserving support for currently existing syntax:
 ```
 - trigger-build-on-pr-review: true
 ```

Change-Id: I554129c779161b47cba4566f7821ef7590a242e0
mika pushed a commit to sipwise/jenkins-job-builder that referenced this pull request Apr 29, 2024
@iwane-pl
New permissions option for GitHub PR Comment Build plugin
aa9897d 
In version 78.v2dcf62ba199b GitHub Pull Request Comment Build Plugin
introduced permissions check for users triggering jobs with comments.
This added a new checkbox/XML element that allows untrusted users to
trigger builds.
(see jenkinsci/github-pr-comment-build-plugin#46)

This commit adds support for this option by allowing dictionary syntax for GH PR Comment Build plugin:
 ```
 - trigger-build-on-pr-review:
    allow-untrusted-users: true
 ```
 while preserving support for currently existing syntax:
 ```
 - trigger-build-on-pr-review: true
 ```

Change-Id: I554129c779161b47cba4566f7821ef7590a242e0
mika pushed a commit to sipwise/jenkins-job-builder that referenced this pull request Apr 29, 2024
@iwane-pl
New permissions option for GitHub PR Comment Build plugin
6c7e3dc 
In version 78.v2dcf62ba199b GitHub Pull Request Comment Build Plugin
introduced permissions check for users triggering jobs with comments.
This added a new checkbox/XML element that allows untrusted users to
trigger builds.
(see jenkinsci/github-pr-comment-build-plugin#46)

This commit adds support for this option by allowing dictionary syntax for GH PR Comment Build plugin:
 ```
 - trigger-build-on-pr-review:
    allow-untrusted-users: true
 ```
 while preserving support for currently existing syntax:
 ```
 - trigger-build-on-pr-review: true
 ```

Change-Id: I554129c779161b47cba4566f7821ef7590a242e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluesliverx bluesliverx bluesliverx approved these changes

@jetersen jetersen jetersen approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restrict build trigger to project group members
3 participants
@lprimak @bluesliverx @jetersen