Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added "allow multiple builds" checkboxes #47

Closed
wants to merge 1 commit into from
Closed

added "allow multiple builds" checkboxes #47

wants to merge 1 commit into from

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented Aug 19, 2022

optionally turn off functionality introduced in #41
for the other 1% of people wanting multiple builds triggered per event

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@bluesliverx
Copy link
Contributor

I think it might be better to implement a check if a build has started for the specific job so that we don't have duplicates. I'll investigate that, but this will work as a backup in case that doesn't pan out. However, I'm really trying to avoid death by checkboxes here, so I'm hesitant to merge it.

@lprimak
Copy link
Contributor Author

lprimak commented Sep 1, 2022

@bluesliverx see this #27 (comment)
I don’t think the queue has to be checked.
I think if the above can be fixed it’s good to go. I think it’s very simple I just don’t have the time to work on it

@lprimak
Copy link
Contributor Author

lprimak commented Sep 9, 2022

superseded by #48

@lprimak lprimak closed this Sep 9, 2022
@lprimak lprimak deleted the multi-build-checkbox branch September 9, 2022 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants