Correctly ignore non-label events in label event handler - #66
Merged
bluesliverx merged 1 commit intoMar 1, 2024
Merged
Conversation
|
Yes! Thank you. This is exactly the kind of change I was about to make having hit the same issue & realised it was exploding on other random events that don't have |
sparrowt
approved these changes
Mar 1, 2024
sparrowt
left a comment
There was a problem hiding this comment.
Apparently I have the ability to approve this - LGTM! 👍 No idea about how a new release of this plugin gets made though.
Contributor
|
Thanks for the contribution! I don't remember how new releases get done either (hopefully it's just built into GitHub actions but this is an older repo for me), but I'll work on that. |
Contributor
|
This is released in 103.vc8919acf2a6b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following error that occurs in our jenkins log on each GitHub event that is not of action
labeled:Testing done
Tested on our internal jenkins test instance.