Add tests

jenkinsci · Oct 18, 2018 · ec9e0b4 · ec9e0b4
1 parent 7fce9e0
commit ec9e0b4
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 6 deletions.
diff --git a/src/main/java/com/github/terma/jenkins/githubprcoveragestatus/CloverParser.java b/src/main/java/com/github/terma/jenkins/githubprcoveragestatus/CloverParser.java
@@ -64,4 +64,5 @@ public float get(final String cloverFilePath) {
         if (statements == 0) return 0;
         else return coveredStatements / statements;
     }
-}
+
+}
diff --git a/src/main/java/com/github/terma/jenkins/githubprcoveragestatus/CoberturaParser.java b/src/main/java/com/github/terma/jenkins/githubprcoveragestatus/CoberturaParser.java
@@ -64,4 +64,6 @@ public float get(String coberturaFilePath) {
             throw new RuntimeException(e);
         }
     }
+
+
 }
diff --git a/src/main/java/com/github/terma/jenkins/githubprcoveragestatus/CompareCoverageAction.java b/src/main/java/com/github/terma/jenkins/githubprcoveragestatus/CompareCoverageAction.java
@@ -29,17 +29,14 @@
 import hudson.tasks.Publisher;
 import hudson.tasks.Recorder;
 import jenkins.tasks.SimpleBuildStep;
-import org.kohsuke.github.*;
+import org.kohsuke.github.GHRepository;
 import org.kohsuke.stapler.DataBoundConstructor;
 import org.kohsuke.stapler.DataBoundSetter;
 
 import javax.annotation.Nonnull;
 import java.io.IOException;
 import java.io.PrintStream;
 import java.io.PrintWriter;
-import java.util.ArrayList;
-import java.util.List;
-import java.util.Locale;
 import java.util.Map;
 
 /**

diff --git a/src/main/java/com/github/terma/jenkins/githubprcoveragestatus/CoverageReportParser.java b/src/main/java/com/github/terma/jenkins/githubprcoveragestatus/CoverageReportParser.java
@@ -20,4 +20,5 @@
 interface CoverageReportParser {
 
     float get(String filePath);
+
 }
diff --git a/src/main/java/com/github/terma/jenkins/githubprcoveragestatus/JacocoParser.java b/src/main/java/com/github/terma/jenkins/githubprcoveragestatus/JacocoParser.java
@@ -31,7 +31,6 @@
     <counter type="METHOD" missed="1" covered="2"/>
     <counter type="CLASS" missed="0" covered="1"/>
  */
-
 class JacocoParser implements CoverageReportParser {
 
     private List<String> coverageTypes = new ArrayList<String>() {{

diff --git a/src/test/java/com/github/terma/jenkins/githubprcoveragestatus/JacocoParserTest.java b/src/test/java/com/github/terma/jenkins/githubprcoveragestatus/JacocoParserTest.java
@@ -40,6 +40,22 @@ public void extractCoverageFromJacocoReportWhenNoLinesOfCode() throws IOExceptio
         Assert.assertEquals(0, new JacocoParser("LINE").get(filePath), 0.1);
     }
 
+    @Test
+    public void extractInstructionCoverageFromJacocoReportWhenCoverageTypeNull() throws IOException {
+        String filePath = JacocoParserTest.class.getResource(
+                "/com/github/terma/jenkins/githubprcoveragestatus/JacocoParserTest/jacoco.xml").getFile();
+
+        Assert.assertEquals(0.22, new JacocoParser(null).get(filePath), 0.1);
+    }
+
+    @Test
+    public void extractInstructionCoverageFromJacocoReportWhenCoverageTypeUnknown() throws IOException {
+        String filePath = JacocoParserTest.class.getResource(
+                "/com/github/terma/jenkins/githubprcoveragestatus/JacocoParserTest/jacoco.xml").getFile();
+
+        Assert.assertEquals(0.22, new JacocoParser("random").get(filePath), 0.1);
+    }
+
     @Test
     public void throwExceptionWhenExtractCoverageFromJacocoAndNoLineTag() throws IOException {
         String filePath = JacocoParserTest.class.getResource(