Do not build draft MRs #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basilevs
changed the title
jetersen
approved these changes
Feb 9, 2024
jonasgroenke
reviewed
Feb 9, 2024
| request.setGitLabApi(gitLabApi); | ||
| request.setProject(gitlabProject); | ||
| request.setMembers(getMembers()); | ||
| if (request.isFetchBranches()) { | ||
| request.setBranches(gitLabApi.getRepositoryApi().getBranches(gitlabProject)); | ||
| } | ||
| Predicate<MergeRequest> filter = ignore -> false; |
There was a problem hiding this comment.
The default should be true, otherwise all mr`s are filtered out or when alwaysIgnoreMRWorkInProgress is not set or?
This was referenced Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respect "Ignore builds for Work In Progress MRs" job property during project rescan.
Before the change:
"Ignore builds for Work In Progress MRs" job property was respected while handling Gitlab events, but was ignored during project scan.
After the change:
"Ignore builds for Work In Progress MRs" job property is always respected (no Draft MRs are built if property is set).
Fixes #384.
Caveat
The job property is hidden in "Webhook Listener Conditions" behavior and is already applied when handling webhooks, but from usability point of view the discrepancy in behavior for hook and scan handling is a bug.
Testing done
Submitter checklist