Fix setter methods in Log comment trait #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markjacksonfishing
approved these changes
May 26, 2020
jetersen
requested changes
May 27, 2020
Comment on lines
41
to
42
| this.sudoUser = sudoUser; | ||
| } |
There was a problem hiding this comment.
indents off
Suggested change
| this.sudoUser = sudoUser; | |
| } | |
| this.sudoUser = sudoUser; | |
| } |
| @@ -15,7 +15,7 @@ | |||
| @NonNull | |||
| private String sudoUser = ""; | |||
|
|
|||
| private boolean logSuccess = false; | |||
| private boolean logSuccessOnly; | |||
There was a problem hiding this comment.
Revert the rename as you only needed to fix the getter actually.
|
@jetersen Thanks for noting that. I almost didn't consider data loss. 😓 |
baymac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log comment trait's fields were not final so the object values and the serialised values were different.Update: The databoundsetter methods were not properly named.