Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlabCommitStatus does not work with gitlab 16.0.1 #1498

Open
rlagoue opened this issue Jun 4, 2023 · 16 comments
Open

gitlabCommitStatus does not work with gitlab 16.0.1 #1498

rlagoue opened this issue Jun 4, 2023 · 16 comments
Labels
bug For changelog: Minor bug. Will be listed after features

Comments

@rlagoue
Copy link

rlagoue commented Jun 4, 2023

Jenkins and plugins versions report

Any attempt to update the commit status on Gitlab (version 16.0.1) fails with the error code "Failed to retrieve projectId for project ".

After investigation I found out that it is caused by an api change on the gitlab side. The endpoint "/projects/" no more works properly with project name as value, only project id are accepted instead.

The problem occurs on the version [1.7.14] of gitlab-plugin

What Operating System are you using (both controller, and any agents involved in the problem)?

Ubuntu 22.04

Reproduction steps

  1. Install gitlab plugin as recommended in the docs
  2. create jenkins job that update the build status on the gitlab commit
  3. run the job

Expected Results

The jenkins gitlab plugin is able to pass the build status to the gitlab commit

Actual Results

Gitlab responds with a 404 error code when attempting to fetch the project data by "name with namespace"

Anything else?

No response

@rlagoue rlagoue added the bug For changelog: Minor bug. Will be listed after features label Jun 4, 2023
@krisstern
Copy link
Member

Also reported in #1496.

Thanks @rlagoue for reporting the issue, we are currently working on modernizing the GitLab Plugin over the summer for GSoC, and have plans to fix this issue as well. Will keep you posted of any updates.

@drakenfly
Copy link

Any updates?

@krisstern
Copy link
Member

Hi @drakenfly The GSoC project is still in progress and will not conclude until later in the summer. So there may not be any updates before then.

@robross0606
Copy link

This is a pretty big problem to leave un-fixed pending a complete rework for GSoC. Our entire set of project pipelines is dead in the water until this is fixed.

@krisstern
Copy link
Member

My apologies, let me try and get this fixed with a patch this week.

@robross0606
Copy link

This might be the root cause: https://docs.gitlab.com/ee/update/deprecations.html?removal_milestone=16.0#legacy-urls-replaced-or-removed

The description says "GitLab APIs are not affected by this change" but that may be incorrect.

@robross0606
Copy link

Looks like this indeed impacted webhooks: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/57734.

This was deprecated a while ago, but they removed the automatic redirects in 16.0.

@krisstern
Copy link
Member

Turns out we still need to work out a few testing issues before a new version of GitLab plugin can be released... We are working at it full speed though.

@robross0606
Copy link

Six months later. Any progress?

@MarkEWaite
Copy link
Contributor

Six months later. Any progress?

We've run several tests, but the testing is not complete. Would you like to help with the testing?

@robross0606
Copy link

What kind of testing?

@MarkEWaite
Copy link
Contributor

What kind of testing?

Test the prototype plugin binary in your usual work. Look for places where the new implementation behaves unexpectedly compared to the existing implementation. The automated tests pass, but they are not nearly deep enough to assure that we retain the level of compatibility that users expect.

@robross0606
Copy link

robross0606 commented Jan 9, 2024

Ah, we cannot do that in our current production environment. I would need to stand up a set of completely different servers to do that. Since this bug has been left so long, we've had not choice but to focus our attention on migrating to native GitLab pipelines and we no longer have a set of development/test servers for Jenkins. With this plugin broken for months, we had little choice but to move to something that worked.

@robross0606
Copy link

robross0606 commented Apr 9, 2024

Since we're dead in the water right now and this is dragging for months and months, is there a beta version of this plugin we could use to test?

@krisstern
Copy link
Member

We do some branches to be tested by some users. They are:

  1. [GSoC Milestone 2] Migrating Webhook #1553
  2. [GSoC Milestone 3] Enabling Proxy Settings #1566
  3. Docs: [GSoC Milestone 4] Improving Documentation #1556

We are going to continue working on the modernisation over the next few months. So feel free to test these.

@krisstern
Copy link
Member

If we work fast enough we can turn these PR's into a beta version to be released for testing next month or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features
Projects
None yet
Development

No branches or pull requests

5 participants