Again: Jenkins jobs defined using generated DSL must specify all possible configuration for triggers, publishers, etc

[jakub-bochenski]

Despite #613 it still doesn't seem to work.

I've checked this on a PR build https://ci.jenkins.io/job/Plugins/job/gitlab-plugin/job/PR-664/18/consoleFull
It has the master HEAD integrated: Merging remotes/origin/master commit ab51c7f2f5c585ec20bdcdf8f2d2e301a39a594a into PR head commit 51c3910270c22c1dc3965fdf975d3fa8b49b3564

Still, I'm getting an error when trying to omit any option:

the following options are required and must be specified: triggerOnPush, triggerOnMergeRequest, triggerOnAcceptedMergeRequest, triggerOnClosedMergeRequest, triggerOpenMergeRequestOnPush, triggerOnNoteRequest, noteRegex, skipWorkInProgressMergeRequest, ciSkip, setBuildDescription, addNoteOnMergeRequest, addCiMessage, addVoteOnMergeRequest, acceptMergeRequestOnSuccess, branchFilterType, includeBranchesSpec, excludeBranchesSpec, targetBranchRegex, mergeRequestLabelFilterConfig, secretToken, triggerOnPipelineEvent, triggerOnApprovedMergeRequest

[jakub-bochenski]

This is a workaround, which requires only secretToken:

        void gitlabTrigger(Closure overrides) {
            def closure = {
                gitlab {
                    triggerOnPush false
                    triggerOnMergeRequest true
                    triggerOnAcceptedMergeRequest false
                    triggerOnClosedMergeRequest false
                    triggerOpenMergeRequestOnPush  'source'
                    triggerOnNoteRequest true
                    noteRegex 'Jenkins please retry a build'
                    skipWorkInProgressMergeRequest false
                    ciSkip true
                    setBuildDescription true
                    branchFilterType 'All'
                    includeBranchesSpec ''
                    excludeBranchesSpec ''
                    targetBranchRegex ''
                    triggerOnPipelineEvent false
                    triggerOnApprovedMergeRequest false
                    addNoteOnMergeRequest false
                    addCiMessage false
                    addVoteOnMergeRequest false
                    acceptMergeRequestOnSuccess false
                    mergeRequestLabelFilterConfig{
                        include ''
                        exclude ''
                    }
                    with overrides
                }
            }
            closure.delegate = overrides.delegate
            closure()
        }

Usage:

                                triggers {
                                    gitlabTrigger {
                                        secretToken 'effaced'
                                    }
                                }

[omehegan]

@g-dx since you wrote the original fix for this issue, can you comment on this?

[g-dx]

We have had v1.5.2 deployed on our Jenkins cluster for at least a month and all is working as expected (i.e. no need to specify all options).

@jakub-bochenski is this still an issue for you?

[jakub-bochenski]

I can't reproduce this on 1.5.2

[benkeil]

The issue is still present. I need to set the secretToken .