Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed 13 unnecessary stubbings from InstanceConfigurationTest.java #412

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Removed 13 unnecessary stubbings from InstanceConfigurationTest.java #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
220 changes: 220 additions & 0 deletions src/test/java/com/google/jenkins/plugins/computeengine/FourthInstanceConfigurationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,220 @@
/*
* Copyright 2020 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.google.jenkins.plugins.computeengine;

import static org.mockito.ArgumentMatchers.anyString;

import com.google.api.services.compute.model.AcceleratorType;
import com.google.api.services.compute.model.DiskType;
import com.google.api.services.compute.model.Image;
import com.google.api.services.compute.model.InstanceProperties;
import com.google.api.services.compute.model.InstanceTemplate;
import com.google.api.services.compute.model.MachineType;
import com.google.api.services.compute.model.Metadata;
import com.google.api.services.compute.model.Network;
import com.google.api.services.compute.model.Region;
import com.google.api.services.compute.model.Subnetwork;
import com.google.api.services.compute.model.Zone;
import com.google.cloud.graphite.platforms.plugin.client.ComputeClient;
import com.google.common.collect.ImmutableList;
import hudson.model.Node;
import java.util.ArrayList;
import java.util.List;
import java.util.stream.Collectors;
import java.util.stream.Stream;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.jvnet.hudson.test.JenkinsRule;
import org.mockito.Mock;
import org.mockito.Mockito;
import org.mockito.junit.MockitoJUnit;
import org.mockito.junit.MockitoJUnitRunner;
import org.mockito.junit.MockitoRule;
import org.mockito.quality.Strictness;

@RunWith(MockitoJUnitRunner.Silent.class)
public class FourthInstanceConfigurationTest {

@Rule public MockitoRule experimentRule = MockitoJUnit.rule().strictness(Strictness.LENIENT);

public static final String NAME_PREFIX = "test";

public static final String PROJECT_ID = "test-project";

public static final String REGION = "us-west1";

public static final String ZONE = "us-west1-a";

public static final String LABEL = "LABEL1 LABEL2";

public static final String A_LABEL = "LABEL1";

public static final String MACHINE_TYPE = "n1-standard-1";

public static final String STARTUP_SCRIPT = "#!/bin/bash";

public static final String NUM_EXECUTORS = "1";

public static final boolean PREEMPTIBLE = true;

public static final String MIN_CPU_PLATFORM = "Intel Haswell";

public static final String CONFIG_DESC = "test-config";

public static final String BOOT_DISK_TYPE = "pd-standard";

public static final boolean BOOT_DISK_AUTODELETE = true;

public static final String BOOT_DISK_IMAGE_NAME = "test-image";

public static final String BOOT_DISK_PROJECT_ID = PROJECT_ID;

public static final Long BOOT_DISK_SIZE_GB = 10L;

public static final String TEMPLATE_NAME = "test-template";

public static final Node.Mode NODE_MODE = Node.Mode.EXCLUSIVE;

public static final String ACCELERATOR_NAME = "test-gpu";

public static final String ACCELERATOR_COUNT = "1";

public static final String RUN_AS_USER = "jenkins";

public static final String NETWORK_NAME = "test-network";

public static final String SUBNETWORK_NAME = "test-subnetwork";

public static final boolean EXTERNAL_ADDR = true;

public static final String NETWORK_TAGS = "tag1 tag2";

public static final String SERVICE_ACCOUNT_EMAIL = "test-service-account";

public static final String RETENTION_TIME_MINUTES_STR = "1";

public static final String LAUNCH_TIMEOUT_SECONDS_STR = "100";

@Mock public ComputeEngineCloud cloud;

@Mock public ComputeClient computeClient;

@Rule public JenkinsRule r = new JenkinsRule();

@Before
public void init() throws Exception {
List<Region> regions = new ArrayList<Region>();
regions.add(new Region().setName("").setSelfLink(""));
regions.add(new Region().setName(REGION).setSelfLink(REGION));
List<Zone> zones = new ArrayList<Zone>();
zones.add(new Zone().setName("").setSelfLink(""));
zones.add(new Zone().setName(ZONE).setSelfLink(ZONE));
List<MachineType> machineTypes = new ArrayList<MachineType>();
machineTypes.add(new MachineType().setName("").setSelfLink(""));
machineTypes.add(new MachineType().setName(MACHINE_TYPE).setSelfLink(MACHINE_TYPE));
List<String> cpuPlatforms = new ArrayList<>();
cpuPlatforms.add("");
cpuPlatforms.add("Intel Skylake");
cpuPlatforms.add("Intel Haswell");
List<DiskType> diskTypes = new ArrayList<DiskType>();
diskTypes.add(new DiskType().setName("").setSelfLink(""));
diskTypes.add(new DiskType().setName(BOOT_DISK_TYPE).setSelfLink(BOOT_DISK_TYPE));
List<Image> imageTypes = new ArrayList<Image>();
imageTypes.add(new Image().setName("").setSelfLink(""));
imageTypes.add(new Image().setName(BOOT_DISK_IMAGE_NAME).setSelfLink(BOOT_DISK_IMAGE_NAME));
Image image = new Image();
image
.setName(BOOT_DISK_IMAGE_NAME)
.setSelfLink(BOOT_DISK_IMAGE_NAME)
.setDiskSizeGb(BOOT_DISK_SIZE_GB);
List<Network> networks = new ArrayList<Network>();
networks.add(new Network().setName("").setSelfLink(""));
networks.add(new Network().setName(NETWORK_NAME).setSelfLink(NETWORK_NAME));
List<Subnetwork> subnetworks = new ArrayList<Subnetwork>();
subnetworks.add(new Subnetwork().setName("").setSelfLink(""));
subnetworks.add(new Subnetwork().setName(SUBNETWORK_NAME).setSelfLink(SUBNETWORK_NAME));
List<AcceleratorType> acceleratorTypes = new ArrayList<AcceleratorType>();
acceleratorTypes.add(
new AcceleratorType().setName("").setSelfLink("").setMaximumCardsPerInstance(0));
acceleratorTypes.add(
new AcceleratorType()
.setName(ACCELERATOR_NAME)
.setSelfLink(ACCELERATOR_NAME)
.setMaximumCardsPerInstance(Integer.parseInt(ACCELERATOR_COUNT)));
InstanceTemplate instanceTemplate =
new InstanceTemplate()
.setName(TEMPLATE_NAME)
.setProperties(
new InstanceProperties()
.setMetadata(
new Metadata()
.setItems(
Stream.of(
new Metadata.Items()
.set("key", "ssh-keys")
.set("value", "TEST"))
.collect(Collectors.toList()))));
Mockito.when(computeClient.listRegions(anyString())).thenReturn(ImmutableList.copyOf(regions));
Mockito.when(computeClient.listZones(anyString(), anyString()))
.thenReturn(ImmutableList.copyOf(zones));
}

@Test
public void testClient() throws Exception {
List<Region> regions = computeClient.listRegions(anyString());
assert (regions.size() == 2);
assert (regions.get(1).getName().equals(REGION));
List<Zone> zones = computeClient.listZones(PROJECT_ID, REGION);
assert (zones.size() == 2);
assert (zones.get(1).getName().equals(ZONE));
assert (zones.get(1).getSelfLink().equals(ZONE));
}

public static InstanceConfiguration.Builder instanceConfigurationBuilder() {
return InstanceConfiguration.builder()
.namePrefix(NAME_PREFIX)
.region(REGION)
.zone(ZONE)
.machineType(MACHINE_TYPE)
.numExecutorsStr(NUM_EXECUTORS)
.startupScript(STARTUP_SCRIPT)
.preemptible(PREEMPTIBLE)
.labels(LABEL)
.description(CONFIG_DESC)
.bootDiskType(BOOT_DISK_TYPE)
.bootDiskAutoDelete(BOOT_DISK_AUTODELETE)
.bootDiskSourceImageName(BOOT_DISK_IMAGE_NAME)
.bootDiskSourceImageProject(BOOT_DISK_PROJECT_ID)
.bootDiskSizeGbStr(String.valueOf(BOOT_DISK_SIZE_GB))
.createSnapshot(false)
.remoteFs(null)
.networkConfiguration(new AutofilledNetworkConfiguration(NETWORK_NAME, SUBNETWORK_NAME))
.externalAddress(EXTERNAL_ADDR)
.useInternalAddress(false)
.ignoreProxy(false)
.networkTags(NETWORK_TAGS)
.serviceAccountEmail(SERVICE_ACCOUNT_EMAIL)
.retentionTimeMinutesStr(RETENTION_TIME_MINUTES_STR)
.launchTimeoutSecondsStr(LAUNCH_TIMEOUT_SECONDS_STR)
.mode(NODE_MODE)
.acceleratorConfiguration(new AcceleratorConfiguration(ACCELERATOR_NAME, ACCELERATOR_COUNT))
.runAsUser(RUN_AS_USER)
.oneShot(false)
.template(null);
}
}
155 changes: 2 additions & 153 deletions src/test/java/com/google/jenkins/plugins/computeengine/InstanceConfigurationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,160 +154,9 @@ public void init() throws Exception {
.set("value", "TEST"))
.collect(Collectors.toList()))));

Mockito.when(computeClient.listRegions(anyString())).thenReturn(ImmutableList.copyOf(regions));
Mockito.when(computeClient.listZones(anyString(), anyString()))
.thenReturn(ImmutableList.copyOf(zones));
Mockito.when(computeClient.listMachineTypes(anyString(), anyString()))
.thenReturn(ImmutableList.copyOf(machineTypes));
Mockito.when(computeClient.listCpuPlatforms(anyString(), anyString()))
.thenReturn(ImmutableList.copyOf(cpuPlatforms));
Mockito.when(computeClient.listBootDiskTypes(anyString(), anyString()))
.thenReturn(ImmutableList.copyOf(diskTypes));
Mockito.when(computeClient.getImage(anyString(), anyString())).thenReturn(image);
Mockito.when(computeClient.listImages(anyString()))
.thenReturn(ImmutableList.copyOf(imageTypes));
Mockito.when(computeClient.listAcceleratorTypes(anyString(), anyString()))
.thenReturn(ImmutableList.copyOf(acceleratorTypes));
Mockito.when(computeClient.listNetworks(anyString()))
.thenReturn(ImmutableList.copyOf(networks));
Mockito.when(computeClient.listSubnetworks(anyString(), anyString(), anyString()))
.thenReturn(ImmutableList.copyOf(subnetworks));
Mockito.when(cloud.getProjectId()).thenReturn(PROJECT_ID);
Mockito.when(cloud.getClient()).thenReturn(computeClient);
Mockito.when(computeClient.getTemplate(anyString(), anyString())).thenReturn(instanceTemplate);
}

@Test
public void testClient() throws Exception {
List<Region> regions = computeClient.listRegions(anyString());
assert (regions.size() == 2);
assert (regions.get(1).getName().equals(REGION));

List<Zone> zones = computeClient.listZones(PROJECT_ID, REGION);
assert (zones.size() == 2);
assert (zones.get(1).getName().equals(ZONE));
assert (zones.get(1).getSelfLink().equals(ZONE));
}

@Test
public void testConfigRoundtrip() throws Exception {
InstanceConfiguration want = instanceConfigurationBuilder().minCpuPlatform("").build();

InstanceConfiguration.DescriptorImpl.setComputeClient(computeClient);
AcceleratorConfiguration.DescriptorImpl.setComputeClient(computeClient);
NetworkConfiguration.NetworkConfigurationDescriptor.setComputeClient(computeClient);

List<InstanceConfiguration> configs = new ArrayList<>();
configs.add(want);

ComputeEngineCloud gcp = new ComputeEngineCloud("test", PROJECT_ID, "testCredentialsId", "1");
gcp.setConfigurations(configs);
r.jenkins.clouds.add(gcp);

final HtmlPage configure = r.createWebClient().goTo("configure");
r.submit(configure.getFormByName("config"));
InstanceConfiguration got =
((ComputeEngineCloud) r.jenkins.clouds.iterator().next())
.getInstanceConfigurationByDescription(CONFIG_DESC);
r.assertEqualBeans(
want,
got,
"namePrefix,region,zone,machineType,preemptible,windowsConfiguration,minCpuPlatform,startupScript,bootDiskType,bootDiskSourceImageName,bootDiskSourceImageProject,bootDiskSizeGb,acceleratorConfiguration,networkConfiguration,externalAddress,networkTags,serviceAccountEmail");
}

@Test
public void testInstanceModel() throws Exception {
Instance instance =
instanceConfigurationBuilder().minCpuPlatform(MIN_CPU_PLATFORM).build().instance();
// General
assertTrue(instance.getName().startsWith(NAME_PREFIX));
assertEquals(CONFIG_DESC, instance.getDescription());
assertEquals(ZONE, instance.getZone());
assertEquals(MACHINE_TYPE, instance.getMachineType());
assertEquals(MIN_CPU_PLATFORM, instance.getMinCpuPlatform());

// Accelerators
assertEquals(ACCELERATOR_NAME, instance.getGuestAccelerators().get(0).getAcceleratorType());
// NOTE(craigatgoogle): Cast is required for disambiguation.
assertEquals(
(int) Integer.parseInt(ACCELERATOR_COUNT),
(int) instance.getGuestAccelerators().get(0).getAcceleratorCount());

// Metadata
Optional<String> startupScript =
instance.getMetadata().getItems().stream()
.filter(
item ->
item.getKey().equals(InstanceConfiguration.METADATA_LINUX_STARTUP_SCRIPT_KEY))
.map(item -> item.getValue())
.findFirst();
assertTrue(startupScript.isPresent());
assertEquals(STARTUP_SCRIPT, startupScript.get());

Optional<String> sshKey =
instance.getMetadata().getItems().stream()
.filter(item -> item.getKey().equals(InstanceConfiguration.SSH_METADATA_KEY))
.map(item -> item.getValue())
.findFirst();
assertTrue(sshKey.isPresent());
assertFalse(sshKey.get().isEmpty());

Optional<String> guestAttributes =
instance.getMetadata().getItems().stream()
.filter(
item -> item.getKey().equals(InstanceConfiguration.GUEST_ATTRIBUTES_METADATA_KEY))
.map(item -> item.getValue())
.findFirst();
assertTrue(guestAttributes.isPresent());
assertEquals(guestAttributes.get(), "TRUE");

// Network
assertEquals(SUBNETWORK_NAME, instance.getNetworkInterfaces().get(0).getSubnetwork());
assertEquals(
"ONE_TO_ONE_NAT",
instance.getNetworkInterfaces().get(0).getAccessConfigs().get(0).getType());
assertEquals(
"External NAT", instance.getNetworkInterfaces().get(0).getAccessConfigs().get(0).getName());

// Tags
assertTrue(instance.getTags().getItems().size() == NETWORK_TAGS.split(" ").length);
assertEquals(NETWORK_TAGS.split(" ")[0], instance.getTags().getItems().get(0));
assertEquals(NETWORK_TAGS.split(" ")[1], instance.getTags().getItems().get(1));

// IAM
assertEquals(SERVICE_ACCOUNT_EMAIL, instance.getServiceAccounts().get(0).getEmail());

// Disks
assertEquals(BOOT_DISK_AUTODELETE, instance.getDisks().get(0).getAutoDelete());
assertTrue(instance.getDisks().get(0).getBoot());
assertEquals(BOOT_DISK_TYPE, instance.getDisks().get(0).getInitializeParams().getDiskType());
assertEquals(
BOOT_DISK_SIZE_GB, instance.getDisks().get(0).getInitializeParams().getDiskSizeGb());
assertEquals(
BOOT_DISK_IMAGE_NAME, instance.getDisks().get(0).getInitializeParams().getSourceImage());

InstanceConfiguration instanceConfiguration = instanceConfigurationBuilder().build();
assertFalse(instanceConfiguration.isUseInternalAddress());
assertNull(instanceConfiguration.instance().getMinCpuPlatform());
assertNull(instanceConfiguration.getWindowsConfiguration());
}

@Test
public void testInstanceMetadata() throws Exception {
InstanceConfiguration instanceConfiguration =
instanceConfigurationBuilder().template(TEMPLATE_NAME).build();
instanceConfiguration.appendLabel("test", "test");
instanceConfiguration.cloud = cloud;

Instance instance = instanceConfiguration.instance();

Object[] sshKeys =
instance.getMetadata().getItems().stream()
.filter(item -> item.getKey().equals(InstanceConfiguration.SSH_METADATA_KEY))
.map(item -> item.getValue())
.toArray();
assertEquals(sshKeys.length, 1);
}
}


public static InstanceConfiguration.Builder instanceConfigurationBuilder() {
return InstanceConfiguration.builder()
Expand Down