Remove ReleaseTrack and redundant config methods.

jenkinsci · May 23, 2020 · e06aa74 · e06aa74
1 parent b40660a
commit e06aa74
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 59 deletions.
diff --git a/.../java/org/jenkinsci/plugins/googleplayandroidpublisher/GooglePlayBuildStepDescriptor.java b/.../java/org/jenkinsci/plugins/googleplayandroidpublisher/GooglePlayBuildStepDescriptor.java
@@ -20,7 +20,6 @@
 import static hudson.Util.fixEmptyAndTrim;
 import static hudson.Util.tryParseNumber;
 import static hudson.model.Item.EXTENDED_READ;
-import static org.jenkinsci.plugins.googleplayandroidpublisher.ReleaseTrack.getConfigValues;
 import static org.jenkinsci.plugins.googleplayandroidpublisher.Util.REGEX_VARIABLE;
 
 public abstract class GooglePlayBuildStepDescriptor<T extends BuildStep & Describable<T>>
@@ -84,13 +83,6 @@ private static ListBoxModel getCredentialsListBox(Item item) {
         return listBox;
     }
 
-    public FormValidation doCheckApkFilesPattern(@QueryParameter String value) {
-        if (fixEmptyAndTrim(value) == null) {
-            return FormValidation.error("An APK file path or pattern is required");
-        }
-        return FormValidation.ok();
-    }
-
     public FormValidation doCheckTrackName(@QueryParameter String value) {
         if (fixEmptyAndTrim(value) == null) {
             return FormValidation.error("A release track is required");
@@ -113,11 +105,8 @@ public FormValidation doCheckRolloutPercentage(@QueryParameter String value) {
     }
 
     public ComboBoxModel doFillTrackNameItems() {
-        return new ComboBoxModel(getConfigValues());
-    }
-
-    public ComboBoxModel doFillRolloutPercentageItems() {
-        return null;
+        // Auto-complete the default track names, though users can also enter custom track names
+        return new ComboBoxModel("internal", "alpha", "beta", "production");
     }
 
     public boolean isApplicable(Class<? extends AbstractProject> c) {

diff --git a/src/main/java/org/jenkinsci/plugins/googleplayandroidpublisher/ReleaseTrack.java b/src/main/java/org/jenkinsci/plugins/googleplayandroidpublisher/ReleaseTrack.java