[JENKINS-70080] Do not generate invalid bytecode for field assignments that use compound operators #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s that use compound operators
dwnusbaum
commented
Feb 6, 2023
| @@ -1131,4 +1131,93 @@ public void sandboxSupportsReturnStatementsInClosures() throws Exception { | |||
| "Script2.result=ArrayList", | |||
| "Script2.result"); | |||
| } | |||
|
|
|||
| @Test | |||
| public void sandboxSupportsFinalFields() { | |||
There was a problem hiding this comment.
These first two tests are just regression tests that demonstrate why we need this whole special case in the first place.
| } | ||
|
|
||
| @Test | ||
| public void sandboxDoesNotPerformImplicitCastsForOverloadedOperators() { |
There was a problem hiding this comment.
I just added this because we did not already have any tests that explicitly covered this scenario.
car-roll
reviewed
Feb 7, 2023
src/main/java/org/kohsuke/groovy/sandbox/SandboxTransformer.java
Outdated
Show resolved
Hide resolved
car-roll
approved these changes
Feb 7, 2023
Co-authored-by: Carroll Chiou <cchiou@cloudbees.com>
basil
approved these changes
Mar 13, 2023
…TrackingClassCodeExpressionTransformer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-70080.
The SECURITY-2824 fix (5202432) inadvertently caused sandbox-transformed field assignments that use compound operators to generate invalid bytecode.