Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add controller.JCasC.configMapAnnotations to allow setting annotations on the JCasC ConfigMaps #1123

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

hrivera-ntap
Copy link
Contributor

@hrivera-ntap hrivera-ntap commented Jun 7, 2024

What does this PR do?

This PR provides a new parameter controller.JCasC.configMapAnnotations that allows for customizing the annotations on all of the JCasC config map resources that are templated out.

If you modified files in the ./charts/jenkins/ directory, please also include the following:

Submitter checklist

  • I bumped the "version" key in ./charts/jenkins/Chart.yaml.
  • I added a new changelog entry to ./charts/jenkins/CHANGELOG.md.
  • I followed the technical requirements.
  • I ran .github/helm-docs.sh from the project root.

Special notes for your reviewer

@hrivera-ntap hrivera-ntap requested a review from a team as a code owner June 7, 2024 14:21
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timja timja enabled auto-merge (squash) June 7, 2024 14:30
@timja timja merged commit 7a23d18 into jenkinsci:main Jun 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to provide annotations to the jcasc config configmap
2 participants