octane fixes for 5.5.4-beta #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is used with old Octane
…is used with old Octane
regression in UFT discovery when new Jenkins plugin is used with old Octane
…peline directly from jenkins
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -546,7 +554,7 @@ public static FreeStyleProject createExecutor(DiscoveryInfo discoveryInfo) { | |||
| * @param uftExecutorJobNameWithTestRunner | |||
| * @return | |||
| */ | |||
| public static FreeStyleProject createExecutorByJobName(String uftExecutorJobNameWithTestRunner) { | |||
| public static FreeStyleProject createExecutorByJobName(String uftExecutorJobNameWithTestRunner) throws IOException { | |||
There was a problem hiding this comment.
Refactor this method to reduce its Cognitive Complexity from 25 to the 15 allowed.
| } | ||
| if (parameterDefinition != null && testRunnerLogicalName.equals(parameterDefinition.getDefaultParameterValue().getValue().toString())) { | ||
| foundDiscoveryJob = job; | ||
|
|
||
| if(replaceParams){ |
There was a problem hiding this comment.
Avoid deeply nested control flow statements.
| @@ -323,7 +323,7 @@ private static FreeStyleProject getDiscoveryJobForUftExecutor(DiscoveryInfo disc | |||
| } | |||
| } | |||
|
|
|||
| private static FreeStyleProject getDiscoveryJobForTestRunner(DiscoveryInfo discoveryInfo) { | |||
| private static FreeStyleProject getDiscoveryJobForUftTestRunner(DiscoveryInfo discoveryInfo) { | |||
There was a problem hiding this comment.
Method getDiscoveryJobForUftTestRunner has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
… empty values throws exception.
Defect #733048 Adding new Octane Server configuration in jenkins with…
…peline directly from jenkins - update SDK
…peline directly from jenkins - update SDK
|
Code Climate has analyzed commit 40d471f and detected 3 issues on this pull request. Here's the issue category breakdown:
Note: there is 1 critical issue. View more on Code Climate. |
grount
pushed a commit
that referenced
this pull request
Apr 15, 2019
defect #616017: [Jenkins] can "run successfully" disabled job from Octane
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes part of https://issues.jenkins-ci.org/browse/JENKINS-54458