Octane fixes 5.6.5 #217
Merged
Octane fixes 5.6.5 #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pace configuration
… to groovy script with command "convertTestsToRun"
…-job add maven support for pipeline job (for module name detection)
…s 2.107.1+ because of Security hardening
… seen in Octane using 5.6.5 plugin
Uft discovery job is not working correctly in Jenkins 2.107.1+ because of Security hardening
defect #779056 : Commits on branches in a multibranch context are not seen in Octane using 5.6.5 plugin
…s 2.107.1+ because of Security hardening
defect #761022 : Uft discovery job is not working correctly in Jenkins 2.107.1+ because of Security hardening
tech : test result are not received in workflow job - when job has workspace action with workspace =null (because of strange configuration of node)
US #737054: SonarQube integration - vulnerabilities
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| Integer buildNumber = Integer.valueOf(buildId, 10); | ||
| if (isValidJenkinsBuildNumber(jenkinsProject, buildNumber)) { | ||
| AbstractBuild build = getBuild(jenkinsProject, buildNumber); | ||
| if (build != null && isBuildExpectingToGetWebhookCall(build) && !isBuildAlreadyGotWebhookCall(build)) { |
There was a problem hiding this comment.
Avoid deeply nested control flow statements.
grount
approved these changes
Jan 20, 2019
|
Approved for test build |
Try to use existing credentials then creating UFT test runner
| @@ -291,8 +291,8 @@ private static FreeStyleProject getDiscoveryJobForUftExecutor(DiscoveryInfo disc | |||
|
|
|||
| setScmRepository(discoveryInfo.getScmRepository(), discoveryInfo.getScmRepositoryCredentialsId(), proj, false); | |||
| setBuildDiscarder(proj, 20); | |||
| addConstantParameter(proj, UftConstants.EXECUTOR_ID_PARAMETER_NAME, discoveryInfo.getExecutorId(), "ALM Octane testing tool connection ID"); | |||
| addConstantParameter(proj, UftConstants.EXECUTOR_LOGICAL_NAME_PARAMETER_NAME, discoveryInfo.getExecutorLogicalName(), "ALM Octane testing tool connection logical name"); | |||
| addConstantParameter(proj, UftConstants.EXECUTOR_ID_PARAMETER_NAME, discoveryInfo.getExecutorId(), "ALM Octane test runner ID"); | |||
There was a problem hiding this comment.
Define a constant instead of duplicating this literal "ALM Octane test runner ID" 4 times.
| addConstantParameter(proj, UftConstants.EXECUTOR_ID_PARAMETER_NAME, discoveryInfo.getExecutorId(), "ALM Octane testing tool connection ID"); | ||
| addConstantParameter(proj, UftConstants.EXECUTOR_LOGICAL_NAME_PARAMETER_NAME, discoveryInfo.getExecutorLogicalName(), "ALM Octane testing tool connection logical name"); | ||
| addConstantParameter(proj, UftConstants.EXECUTOR_ID_PARAMETER_NAME, discoveryInfo.getExecutorId(), "ALM Octane test runner ID"); | ||
| addConstantParameter(proj, UftConstants.EXECUTOR_LOGICAL_NAME_PARAMETER_NAME, discoveryInfo.getExecutorLogicalName(), "ALM Octane test runner logical name"); |
There was a problem hiding this comment.
Define a constant instead of duplicating this literal "ALM Octane test runner logical name" 4 times.
|
Code Climate has analyzed commit 9017883 and detected 3 issues on this pull request. Here's the issue category breakdown:
Note: there are 2 critical issues. View more on Code Climate. |
|
Approved for test build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-55329 : Commits are not reported to Octane from multibranch job
JENKINS-55367 : Uft discovery job is not working correctly in Jenkins 2.107.1+ because of Security hardening
JENKINS-55670 : Add support of sonar vulnerabilities
JENKINS-55695 : Use existing credentials then creating UFT test runner with SCM repository with credentials
update dependencies of sonarcube + recommended updates for workflow plugins