JENKINS-55718 #218
Merged
JENKINS-55718 #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roy-Lu
commented
Jan 22, 2019
Roy-Lu
commented
- Change authentication tool to a singelton.
- Add ApiKeyAuthenticator to login to ALM through a new api. This is for ALM15SSO and ALM1260SSO.
- Enhance the RestAuthenticator to avoid be blocked by some problematic ALM env which generates wrong authenticate point.
Add ApiKeyAuthenticator to login to ALM through a new api. This is for ALM15SSO and ALM1260SSO. Enhance the RestAuthenticator to avoid be blocked by some problematic ALM env which generates wrong authenticate point.
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -34,59 +34,117 @@ | |||
| import com.microfocus.application.automation.tools.sse.sdk.Logger; | |||
| import com.microfocus.application.automation.tools.sse.sdk.ResourceAccessLevel; | |||
| import com.microfocus.application.automation.tools.sse.sdk.Response; | |||
| import sun.rmi.runtime.Log; | |||
There was a problem hiding this comment.
Use classes from the Java API instead of Sun classes.
| } | ||
|
|
||
| private boolean isAlreadyAuthenticated(Response response, String authUser) { | ||
| private boolean checkAuthResponse(Response response, String authUser, Logger logger) { |
There was a problem hiding this comment.
Method checkAuthResponse has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
| @@ -111,44 +168,58 @@ public boolean logout(Client client, String username) { | |||
| * @param logger logger | |||
| * @return null or authenticate point | |||
| */ | |||
| private String isAuthenticated(Client client, Logger logger) { | |||
| private boolean isAuthenticated(Client client, Logger logger) { | |||
There was a problem hiding this comment.
Method isAuthenticated has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
|
|
||
| public boolean login(Client client, String username, String password, Logger logger) { | ||
| public boolean login(Client client, String username, String password, String clientType, Logger logger) { |
There was a problem hiding this comment.
Method login has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
grount
suggested changes
Jan 22, 2019
...a/com/microfocus/application/automation/tools/sse/sdk/authenticator/ApiKeyAuthenticator.java
Show resolved
Hide resolved
...ava/com/microfocus/application/automation/tools/sse/sdk/authenticator/RestAuthenticator.java
Outdated
Show resolved
Hide resolved
...ava/com/microfocus/application/automation/tools/sse/sdk/authenticator/RestAuthenticator.java
Outdated
Show resolved
Hide resolved
...ava/com/microfocus/application/automation/tools/sse/sdk/authenticator/RestAuthenticator.java
Outdated
Show resolved
Hide resolved
| client.getServerUrl(), | ||
| response.getStatusCode())); | ||
| ret = false; | ||
| if (!isAuthenticatePointRight(authenticationPoint, client.getServerUrl(), logger)) { |
There was a problem hiding this comment.
Merge this if statement with the enclosing one.
| client.getServerUrl(), | ||
| response.getStatusCode())); | ||
| ret = false; | ||
| if (!isAuthenticatePointRight(authenticationPoint, client.getServerUrl(), logger)) { |
There was a problem hiding this comment.
These nested if statements could be combined
...ava/com/microfocus/application/automation/tools/sse/sdk/authenticator/RestAuthenticator.java
Outdated
Show resolved
Hide resolved
...ava/com/microfocus/application/automation/tools/sse/sdk/authenticator/RestAuthenticator.java
Show resolved
Hide resolved
|
Please merge this PR using 'Squash and merge'. |
|
Code Climate has analyzed commit 572ab27 and detected 0 issues on this pull request. View more on Code Climate. |
grount
approved these changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.