Migrate from com.google.common.collect.Range and com.google.common.collect.Ranges to java.util.stream.IntStream
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….collect.Ranges` to `java.util.stream.IntStream`
basil
commented
May 9, 2021
| @@ -670,7 +677,7 @@ public void nonExistentProxyAuthFailsTheBuild() throws Exception { | |||
| WorkflowJob proj = j.jenkins.createProject(WorkflowJob.class, "proj"); | |||
| proj.setDefinition(new CpsFlowDefinition( | |||
| "def response = httpRequest url:'"+baseURL()+"/proxyAuth',\n" + | |||
| " proxy: 'http://proxy.example.com:8080',\n" + | |||
| " httpProxy: 'http://proxy.example.com:8080',\n" + | |||
There was a problem hiding this comment.
This test had been passing erroneously. Adding a proper assertion exposed this bug in the test, which is now fixed.
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
com.google.common.collect.Rangeswas removed in Guava 15, so consuming this API is a liability. This PR replaces usages ofcom.google.common.collect.Rangeandcom.google.common.collect.Rangeswith usages ofjava.util.stream.IntStreamto avoid any breakage when running on newer versions of Guava.Before I started this change, I improved the tests to ensure that they were checking for the appropriate error messages for range violations. This gave me confidence that my refactoring was successful. Along the way, I found and fixed a bug in one of the tests as well.