Restore parameterized test

jenkinsci · May 22, 2023 · 9bc1e7d · 9bc1e7d
1 parent d358379
commit 9bc1e7d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 18 deletions.
diff --git a/maven-plugin/pom.xml b/maven-plugin/pom.xml
@@ -10,6 +10,7 @@
     <packaging>maven-plugin</packaging>
     <properties>
         <maven-plugin-tools.version>3.8.1</maven-plugin-tools.version>
+        <junit.version>5.9.3</junit.version>
     </properties>
 
     <prerequisites>
@@ -66,7 +67,13 @@
         <dependency>
             <groupId>org.junit.jupiter</groupId>
             <artifactId>junit-jupiter-api</artifactId>
-            <version>5.9.3</version>
+            <version>${junit.version}</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter-params</artifactId>
+            <version>${junit.version}</version>
             <scope>test</scope>
         </dependency>
         <dependency>

diff --git a/maven-plugin/src/test/java/io/jenkins/tools/incrementals/maven/DetectIndentTest.java b/maven-plugin/src/test/java/io/jenkins/tools/incrementals/maven/DetectIndentTest.java
@@ -1,6 +1,7 @@
 package io.jenkins.tools.incrementals.maven;
 
-import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.MethodSource;
 
 import java.util.Arrays;
 import java.util.Collection;
@@ -15,23 +16,12 @@ public static Collection<Object[]> data() {
     });
   }
 
-  private String input;
-
-  private int size;
-
-  private char type;
-
-  public DetectIndentTest(String input, int size, char type) {
-    this.input = input;
-    this.size = size;
-    this.type = type;
-  }
-
-  @Test
-  public void detectIndentSize() {
+  @ParameterizedTest
+  @MethodSource("data")
+  public void detectIndentSize(String input, int size, char type) {
     DetectIndent detectIndent = new DetectIndent();
     DetectIndent.Indent indent = detectIndent.detect(input);
-    assertEquals(size, indent.size);
-    assertEquals(type, indent.type);
+    assertEquals(size, indent.getSize());
+    assertEquals(type, indent.getType());
   }
 }