Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-51658] add NOOP to reincrementalify #5

Merged
merged 2 commits into from
Jul 17, 2018
Merged

[JENKINS-51658] add NOOP to reincrementalify #5

merged 2 commits into from
Jul 17, 2018

Conversation

jetersen
Copy link
Member

@jetersen jetersen commented Jul 13, 2018 •
edited
Loading

To avoid breaking POM with reincrementalify if POM does not contain revison or changelist a change that jenkinsci/plugin-pom#117 depends on

@jetersen jetersen mentioned this pull request Jul 13, 2018
Merged
jglick
jglick reviewed Jul 14, 2018
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted in the linked PR, we should not need this, so I would rather have the mojo throw MojoExecutionException (IIRC) for ease of debugging.

@jetersen
Copy link
Member Author

Seems reasonable

@jetersen
Copy link
Member Author 

[ERROR] Failed to execute goal io.jenkins.tools.incrementals:incrementals-maven-plugin:1.0-beta-4-SNAPSHOT:reincrementalify (default-cli) on project cloudbees-bitbucket-branch-source: Cannot use reincrementalify before enabling incrementals: Cannot use reincrementalify before enabling incrementals:
[ERROR] Please use 'incrementals:incrementalify' to enable incrementals

@jetersen
Copy link
Member Author

@jglick haven't tested a pom with multiple modules.

@jetersen
Copy link
Member Author

Works fine in multi module 👍

@jglick jglick changed the title add NOOP to reincrementalify [JENKINS-51658] add NOOP to reincrementalify Jul 17, 2018
@jglick
Copy link
Member

jglick commented Jul 17, 2018

AFAICT running the goal twice on an incrementalified project was already a no-op, so this is safe as it should only affect projects which are not set up for Incrementals at all.

@jglick jglick merged commit 98671ef into jenkinsci:master Jul 17, 2018
@jetersen jetersen deleted the reincrementalifyNOOP branch April 19, 2022 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jetersen @jglick