Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build change log point generator to capture affected paths, culprits and commit messages #14

Merged
merged 5 commits into from May 3, 2017

Conversation

adityacs
Copy link
Contributor

Captures below metrics:

Affected paths -- Files changed in the commit
Data type: comma separated string

Culprits -- Authors
Data type: comma separated string

Messages -- Commit messages
Data type: comma separated string

Commit Count -- Total number of commits for the particular build
Data type: int

@adityacs
Copy link
Contributor Author

@asimell I am not sure if it is good practice to store string values which are very long in length in InfluxDB. However, this feature helps to capture metrics on change log. It's good if this is merged.

Copy link
Contributor

@asimell asimell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to influx-java version update, .field() function calls are now deprecated. You should use .addField() instead of .field().

@adityacs
Copy link
Contributor Author

adityacs commented May 3, 2017

@asimell I have made the changes.

@asimell
Copy link
Contributor

asimell commented May 3, 2017

@adityacs The build sends now sends changelog data even if there are no changes or even if the build is not using SCM at all. I doubt this is desired behaviour?

@adityacs
Copy link
Contributor Author

adityacs commented May 3, 2017

@asimell It sends empty data if there are no changes. If there is no SCM it won't send because the build instance will not be of type abstractbuild without scm.
I will change this. I will add a check to read the data and publish only if there is change.

@asimell asimell merged commit 8c8ac90 into jenkinsci:master May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants