Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-47778] Not manage the order in Jenkins Global Configuration #27

Merged
merged 1 commit into from Nov 3, 2017

Conversation

fbelzunc
Copy link
Contributor

@fbelzunc fbelzunc commented Nov 2, 2017

In the latest Jenkins core version, the* ivy-project plugin* is not being correctly rendered in the UI Jenkins Global Configuration - the same is happening with the maven plugin by the way.

The problem seems to come from @extension(ordinal=890). As per Extension documentation

Used for sorting extensions. Extensions will be sorted in the descending order of the ordinal. In other words, the extensions with the highest numbers will be chosen first. This is a rather poor approach to the problem, so its use is generally discouraged.

@fbelzunc fbelzunc changed the title [JENKINS-47778] Not manage the order in Jenkins Global Configuration [FIXED JENKINS-47778] Not manage the order in Jenkins Global Configuration Nov 2, 2017
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original ordinal is definitely wrong and not required, but I do not see how it resolves the issue in general, other sections may collide. Section with Number of executors in the core should have section borders and header. @fbelzunc could you please create a bug for that.

🐝 for this patch anyway

@arothian arothian merged commit 7bf8c79 into jenkinsci:master Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants