Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds branch coverage column #101

Merged
merged 4 commits into from Sep 21, 2018
Merged

Adds branch coverage column #101

merged 4 commits into from Sep 21, 2018

Conversation

MrG00dkat
Copy link
Contributor

Adds branch coverage column for the job view. Also includes refactoring common column to an abstract class.

@centic9
Copy link
Member

centic9 commented Sep 18, 2018

Thanks for this PR!

Are existing setups where the column is in use automatically migrated? If not, is it possible to automatically add the new LineCoverageColumn instead? Or would we need to keep a "Dummy" class in the old place to be compatible?

@MrG00dkat
Copy link
Contributor Author

Thank you for your feedback!
The configuration of the column was lost on a version update. I haven´t found a way to migrate the column configuration to the new column name. A dummy column means, that I also must make a copy of the jelly files. So, I renamed the LineCoverageColumn back to his original name JaCoCoColumn. I think that is the best way. After that the update works fine without losing the column configuration.

@centic9 centic9 merged commit dbd7d70 into jenkinsci:master Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants