Use ASM library plugin #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
added
dependencies
basil
force-pushed
the
asm-library-plugin
branch
2 times, most recently
from
5097e7f
to
b54177c
Compare
basil
force-pushed
the
asm-library-plugin
branch
from
b54177c
to
ce0e126
Compare
jonesbusy
approved these changes
Mar 15, 2024
centic9
approved these changes
Mar 20, 2024
|
Thanks! Looking forward to a release of this PR so that we can remove ASM from Jenkins core and allow users to upgrade ASM through the plugin system instead. |
|
@centic9 would you be so kind as to cut a release, please? That would allow us to move on, as outlined by basil. |
|
Unfortunately uploading a new release broke again for me with an authentication problem during upload "401 Unauthorized", probably something changed somewhere in Jenkins-land, hard to dig into it every few months.... Probably time that one of you guys is added to releasers of this plugin as I cannot invest much time anyway. |
|
Seems after another try it worked now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.jenkins.io/doc/developer/plugin-development/dependencies-and-class-loading/#using-library-wrapper-plugins
Testing done
Passing CI build: https://ci.jenkins.io/job/Plugins/job/jacoco-plugin/job/PR-278/10/