JENKINS-18461 Allow the user to not allocate a public ip address for a slave in a cloudstack cloud #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g to CloudStack clouds
address. Use this option to use the internal ip address when running in an isolated network with advanced networking.
|
Jenkins » jclouds-plugin #72 FAILURE |
|
So 1.6.2-incubating isn't quite out yet - it's in RC right now, and actually, we're about to cut another RC due to a showstopper bug. Otherwise, this sounds good. Will read through it in more detail once we have a real 1.6.2-incubating out. |
|
Thanks. I have it running on a couple of jenkins servers talking to a CloudStack 4.1.1 cloud. So far it seems to work like a charm with the 1.6.2-incubating version. |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
1.6.2-incubating is out today - I'll re-run this PR once it's in Maven Central and then merge/release. |
abayer
added a commit
that referenced
this pull request
Aug 27, 2013
JENKINS-18461 Allow the user to not allocate a public ip address for a slave in a cloudstack cloud
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds an advanced option where the user can select to assign a public ip address to a jenkins slave. This option is useful when cloudstack is running in advanced networking mode and the jenkins server is located in the same isolated network or the isolated network is bridged to a physical vlan. In those cases the slave will use the internal IP address of the slave to connect, this saves a public IPv4 address.