use new-style API tokens for Jenkins >= 2.129.1 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unit_tests/test_users.py
Outdated
| self.users = Users() | ||
|
|
||
| def test_configure_admin_custom_password(self): | ||
| @mock.patch('charms.layer.jenkins.packages.Packages.jenkins_version') |
There was a problem hiding this comment.
For consistency with the approach taken to test the Api() class, I'd suggest to use the same depedency injection technique:
class Users(object):
__init__(self, packages=None):
self._packages = packages or Packages()
This will avoid having to add mock configuration directives like this in the future, in every possible test that indirectly uses the Users() class.
…ching Packages.jenkins_version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #47