Proposed fix for JENKINS-13165

[ronny]

This is a proposed fix for https://issues.jenkins-ci.org/browse/JENKINS-13165 re: Ant 1.8.2+ excluding SCM files (like .git) by default.

I made two assumptions which may not be acceptable. So they're open for discussion.

• minimum Jenkins version changed to 1.463
• user must specify explicitly the exclude glob, never use the default excludes (the alternative is probably to make this user configurable, but I'm not familiar enough with Jenkins' codebase)

[buildhive]

Jenkins » jenkins-clone-workspace-scm-plugin #2 SUCCESS
This pull request looks good
(what's this?)

[davehunt]

I've just hit this issue too. Any chance we can get this merged soon?

[ronny]

I've just uploaded the .hpi file built with the changes in this pull request if anyone's interested in the meantime: https://github.com/downloads/ronny/jenkins-clone-workspace-scm-plugin/clone-workspace-scm.hpi

[abayer]

I've just dealt with the default excludes thing as a configuration option - could you redo your commit without that?

[ronny]

Sorry, I don't quite follow, did you want the third parameter to DirScanner.Glob() to be retrieved from a config option somewhere or did you want me to remove the third parameter altogether? I'm more than happy to change it, just not sure how.

[davehunt]

Any update on this? Its preventing us from upgrading Jenkins and several plugins.

[davehunt]

I believe this was fixed in commit 0bfecda
Should we close this?

[jollychang]

We use Release 0.12 (2013-02-16) and EXCLUDE .git
but still delete them,config as below

<hudson.plugins.ws__cleanup.WsCleanup>
<patterns>
<hudson.plugins.ws__cleanup.Pattern>
<pattern>.git/**</pattern>
<type>EXCLUDE</type>
</hudson.plugins.ws__cleanup.Pattern>
<hudson.plugins.ws__cleanup.Pattern>
<pattern>.gitignore</pattern>
<type>EXCLUDE</type>
</hudson.plugins.ws__cleanup.Pattern>
</patterns>
<deleteDirs>false</deleteDirs>
<skipWhenFailed>false</skipWhenFailed>
<notFailBuild>false</notFailBuild>
<cleanupMatrixParent>false</cleanupMatrixParent>
</hudson.plugins.ws__cleanup.WsCleanup>
</publishers>
<buildWrappers>
<hudson.plugins.ws__cleanup.PreBuildCleanup>
<patterns>
<hudson.plugins.ws__cleanup.Pattern>
<pattern>*.pyc</pattern>
<type>INCLUDE</type>
</hudson.plugins.ws__cleanup.Pattern>
</patterns>
<deleteDirs>false</deleteDirs>
</hudson.plugins.ws__cleanup.PreBuildCleanup>

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests