Skip to content
This repository has been archived by the owner on Feb 27, 2020. It is now read-only.

[FIX JENKINS-35845] Internationalisation for Blue Ocean and JDL #107

Merged
merged 13 commits into from
Nov 17, 2016

Conversation

scherler
Copy link
Collaborator

Description

HEADSUP contains unrelated updates, but I could not make jdl build without it.

All components which needs locale translations being date format or translations have to get this information as properties

+        const {
+            shortFormat = 'MMM DD h:mma Z',
+            longFormat = 'MMM DD YYYY h:mma Z' ,
+        } = this.props;
...
-                date.format('MMM DD YYYY h:mma Z') :
-                date.format('MMM DD h:mma Z');
+                date.format(longFormat) :
+                date.format(shortFormat);

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

@reviewbybees

@scherler scherler merged commit ece5c5d into master Nov 17, 2016
@scherler scherler deleted the JENKINS-35845 branch November 17, 2016 19:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants