Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTMLUnit 3.x #110

Merged
merged 2 commits into from
May 29, 2023
Merged

HTMLUnit 3.x #110

merged 2 commits into from
May 29, 2023

Conversation

timja
Copy link
Member

@timja timja commented May 25, 2023

Part of jenkinsci/jenkins-test-harness#568

Testing done

Tested in stapler and jenkins-test-harness

Upgrade guide:
https://www.htmlunit.org/migration.html

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@@ -124,7 +124,6 @@
<configuration>
<artifactSet>
<includes>
<include>net.sourceforge.htmlunit:*</include>
Copy link
Member Author

@timja timja May 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shaded version was not being used anywhere as far as I can tell so let's not pretend we're doing it anymore

not sure if we fully want to remove the shade plugin or if that will cause issues

@timja timja merged commit 8979204 into jenkinsci:master May 29, 2023
13 checks passed
@timja timja deleted the 3.x branch May 29, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants