Merge pull request #1713 from deadmoose/use_trigger_update

When an AbstractNodeMonitorDescriptor doesn't have a result, request it via triggerUpdate()
jenkinsci · Jul 1, 2015 · 2557e58 · 2557e58
2 parents 76c1e77 + 4299e83
commit 2557e58
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/core/src/main/java/hudson/node_monitors/AbstractNodeMonitorDescriptor.java b/core/src/main/java/hudson/node_monitors/AbstractNodeMonitorDescriptor.java
@@ -170,12 +170,7 @@ protected Map<Computer,T> monitor() throws InterruptedException {
     public T get(Computer c) {
         if(record==null || !record.data.containsKey(c)) {
             // if we don't have the data, schedule the check now
-            if(!isInProgress()) {
-                synchronized(this) {
-                    if(!isInProgress())
-                        new Record().start();
-                }
-            }
+            triggerUpdate();
             return null;
         }
         return record.data.get(c);
@@ -257,7 +252,11 @@ protected boolean markOffline(Computer c) {
      */
     /*package*/ synchronized Thread triggerUpdate() {
         if (inProgress != null) {
-            if (System.currentTimeMillis() > inProgressStarted + getMonitoringTimeOut() + 1000) {
+            if (!inProgress.isAlive()) {
+                LOGGER.log(Level.WARNING, "Previous {0} monitoring activity died without cleaning up after itself",
+                    getDisplayName());
+                inProgress = null;
+            } else if (System.currentTimeMillis() > inProgressStarted + getMonitoringTimeOut() + 1000) {
                 // maybe it got stuck?
                 LOGGER.log(Level.WARNING, "Previous {0} monitoring activity still in progress. Interrupting",
                         getDisplayName());