Skip to content
Permalink
Browse files

[FIXED JENKINS-20008] [FIXED JENKINS-18028] [FIXED JENKINS-18680] #1069

…: support for moving jobs into or out of folders.
  • Loading branch information...
jglick committed Jan 8, 2014
1 parent 554be78 commit 6ca99ff8c241769959dec4b31257a54a22e340a6
@@ -55,6 +55,11 @@
<!-- Record your changes in the trunk here. -->
<div id="trunk" style="display:none"><!--=TRUNK-BEGIN=-->
<ul class=image>
<li class='major rfe'>
Added infrastructure for moving items into or out of folders.
(<a href="https://issues.jenkins-ci.org/browse/JENKINS-20008">issue 20008</a>)
(<a href="https://issues.jenkins-ci.org/browse/JENKINS-18028">issue 18028</a>)
(<a href="https://issues.jenkins-ci.org/browse/JENKINS-18680">issue 18680</a>)
<li class=bug>
<i>Apply</i> buttons did not work in Internet Explorer in compatibility mode.
(<a href="https://issues.jenkins-ci.org/browse/JENKINS-19826">issue 19826</a>)
@@ -362,7 +362,7 @@ public int compare(T o1, T o2) {
* @return the new item (usually the same object as {@code item})
* @throws IOException if the move fails, or some subsequent step fails (directory might have already been moved)
* @throws IllegalArgumentException if the move would really be a rename, or the destination cannot accept the item, or the destination already has an item of that name
* @since TODO
* @since 1.548
*/
public static <I extends AbstractItem & TopLevelItem> I move(I item, DirectlyModifiableTopLevelItemGroup destination) throws IOException, IllegalArgumentException {
DirectlyModifiableTopLevelItemGroup oldParent = (DirectlyModifiableTopLevelItemGroup) item.getParent();
@@ -114,7 +114,7 @@ public void onRenamed(Item item, String oldName, String newName) {
* @param oldFullName the former {@link Item#getFullName}
* @param newFullName the current {@link Item#getFullName}
* @see Items#computeRelativeNamesAfterRenaming
* @since TODO
* @since 1.548
*/
public void onLocationChanged(Item item, String oldFullName, String newFullName) {}

@@ -166,7 +166,7 @@ public static void fireOnUpdated(Item item) {
l.onUpdated(item);
}

/** @since TODO */
/** @since 1.548 */
public static void fireOnDeleted(Item item) {
for (ItemListener l : all()) {
l.onDeleted(item);
@@ -177,7 +177,7 @@ public static void fireOnDeleted(Item item) {
* Calls {@link #onRenamed} and {@link #onLocationChanged} as appropriate.
* @param rootItem the topmost item whose location has just changed
* @param oldFullName the previous {@link Item#getFullName}
* @since TODO
* @since 1.548
*/
public static void fireLocationChange(Item rootItem, String oldFullName) {
String prefix = rootItem.getParent().getFullName();
@@ -31,7 +31,7 @@

/**
* Item group which supports items being directly moved in or out of it.
* @since TODO
* @since 1.548
*/
public interface DirectlyModifiableTopLevelItemGroup extends ModifiableTopLevelItemGroup {

0 comments on commit 6ca99ff

Please sign in to comment.
You can’t perform that action at this time.