Skip to content

Commit

Permalink
jesse wants a comment explaining devaition from pattern
Browse files Browse the repository at this point in the history
  • Loading branch information
stephenc committed Apr 23, 2015
1 parent df83132 commit 7231bac
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions core/src/main/java/hudson/model/Computer.java
Expand Up @@ -1194,6 +1194,15 @@ public String getHostName() throws IOException, InterruptedException {
}

private static class ListPossibleNames extends MasterToSlaveCallable<List<String>,IOException> {
/**
* In the normal case we would use {@link Computer} as the logger's name, however to
* do that we would have to send the {@link Computer} class over to the remote classloader
* and then it would need to be loaded, which pulls in {@link Jenkins} and loads that
* and then that fails to load as you are not supposed to do that. Another option
* would be to export the logger over remoting, with increased complexity as a result.
* Instead we just use a loger based on this class name and prevent any references to
* other classes from being transferred over remoting.
*/
private static final Logger LOGGER = Logger.getLogger(ListPossibleNames.class.getName());

public List<String> call() throws IOException {
Expand Down

0 comments on commit 7231bac

Please sign in to comment.