Skip to content

Commit

Permalink
Bump to a bit longer
Browse files Browse the repository at this point in the history
(Note: mainly bumping for the CI to not fail since I was never able to
see this test fail on my machine [takes ~17 with this change] anyway
other than by running in Docker and aggressively reduce IOPS to 40 using
Docker resource constraints.)

Since we now *actually* sync to disk, this isn't really a regression IMO.
From the very role of AtomicFileWriter, it looks more like a feature or
an improvement than an issue.

So I suspect that anyway 1) we won't see
a lot of bad impact in the wild on most setups (as we generally already
recommend SSDs and so on as per how Jenkins works) and 2) we win anyway
in term of integrity by making sure (well, raising the chances, let's
say) we do write to disk before renaming files.
  • Loading branch information
batmat committed Dec 4, 2017
1 parent 1191bb0 commit f555cb6
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -24,7 +24,7 @@ public class AtomicFileWriterPerfTest {
* <strong>really</strong> bad performance regressions.
*/
@Issue("JENKINS-34855")
@Test(timeout = 30 * 1000L)
@Test(timeout = 50 * 1000L)
public void poorManPerformanceTestBed() throws Exception {
int count = 1000;
while (count-- > 0) {
Expand Down

0 comments on commit f555cb6

Please sign in to comment.