Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Agent => Master security link to point to a non-Apache redirect #2700

Merged
merged 1 commit into from
Jan 16, 2017
Merged

Update the Agent => Master security link to point to a non-Apache redirect #2700

merged 1 commit into from
Jan 16, 2017

Conversation

rtyler
Copy link
Member

@rtyler rtyler commented Jan 3, 2017

This help text points to a very old redirect which is only editable in our
infrastructure Puppet code (which will at some point in the distant future be
removed).

Changing to jenkins.io/redirect means that the destination of this redirect
is easily modified by pull requests to
https://github.com/jenkins-infra/jenkins.io

See also jenkins-infra/jenkins.io#520

@rtyler rtyler force-pushed the global-security-redirect-update branch from 64cf376 to 4e0adbf Compare January 3, 2017 23:30
@daniel-beck
Copy link
Member

So links from older releases will just break? Or are you going to create content/security-144.adoc as well?

@rtyler
Copy link
Member Author

rtyler commented Jan 4, 2017

@daniel-beck this code isn't being removed right now.

I don't know when an appropriate time will be to sunset jenkins-ci.org, but we're stuck running this "catch-all" apache instance for at least another year. I just want to start moving away things as I see them

oleg-nenashev
oleg-nenashev approved these changes Jan 6, 2017
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@oleg-nenashev
Copy link
Member

I doubt we will be ready to deprecate jenkins-ci.org within a foreseeable time without a fallout on old instances, but I suppose we will have to do it. Migrating to the new URLs everywhere is a nice thing in any case

@daniel-beck
Copy link
Member

Wouldn't a redirect URL like agent-to-master-security be better than the pretty indecipherable security-144?

@oleg-nenashev oleg-nenashev added the needs-more-reviews Complex change, which would benefit from more eyes label Jan 7, 2017
@KostyaSha
Copy link
Member

Wouldn't a redirect URL like agent-to-master-security be better than the pretty indecipherable security-144?

agent-to-master-security-144

Update the Agent => Master security link to point to a non-Apache red…
9fbcb99 
…irect

This help text points to a very old redirect which is only editable in our
infrastructure Puppet code (which will at some point in the distant future be
removed).

Changing to jenkins.io/redirect means that the destination of this redirect
is easily modified by pull requests to
https://github.com/jenkins-infra/jenkins.io

See also jenkins-infra/jenkins.io#520
@rtyler rtyler force-pushed the global-security-redirect-update branch from 4e0adbf to 9fbcb99 Compare January 13, 2017 20:44
@rtyler rtyler merged commit 461472f into jenkinsci:master Jan 16, 2017
@rtyler rtyler deleted the global-security-redirect-update branch January 16, 2017 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees

@rtyler rtyler

Labels
needs-more-reviews Complex change, which would benefit from more eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rtyler @daniel-beck @oleg-nenashev @KostyaSha