New general layout using <div>s #1310
Conversation
|
core » jenkins-core #984 SUCCESS |
|
Job config page overlaps sidepanel/widgets between ~990 and ~1320 px window width. Likewise the main page, and the build queue is shrinking again to smaller width than executors list. I doubt this is deliberate? I like the breadcrumb background highlight, but right-arrow (children) and down-arrow (context) behave inconsistently. |
|
At sub 535px, the search box comes down from the menu, but is hidden by the menu. Chrome 35, Win 7. |
|
Every config form asks for confirmation before navigating away even if I haven't edited anything. I don't experience this issue on 1.567 or 1.570. There's a 1px wide area to the right of each breadcrumb context menu down-arrow where the related breadcrumb highlight is shown. |
|
@daniel-beck fixed a) the panel overlaps and b) the breadcrumb inconsistencies. Not sure what you mean about the 1px area to the right of the breadcrumb... can you provide a screenshot? Wrt the form submissions... I tried that and the only time it happened for me was when I made a change on the form, didn't submit and then tried to move of the page. If I didn't make any changes, I was not asked. That makes sense to me, but will compare behaviour from before. @busches The search now disappears on small screens, so the strange behaviour you saw should be fixed now. Thanks a lot guys. |
|
Demo video: Note how the background highlight flickers when moving the pointer between the right arrow (children) and the down arrow (context menu) at ~00:02.54-00:02.62. OS X 10.9.2, Firefox 30.0 (default page zoom), Jenkins 1.572-SNAPSHOT (private-07/03/2014 11:23 GMT-root) |
|
core » jenkins-core #987 UNSTABLE |
|
@daniel-beck ah ok, I know what you mean. I think that was all part of the inconsistent behaviour you originally identified, which was fixed as part of the last commit. I forgot to update the instance running on http://166.78.9.27:8080/ but have done that since, so you can try it out again and see. |
|
Breadcrumb trail looks much better now, and the responsive issue with overlap is gone as well. IMO only really minor issues left that could be fixed later:
The confirmation dialog still appears even if I haven't changed anything about the form. it's probably unrelated though, as the JS stack shows it's caused by an AJAX request populating a select (CVS Projectset » Advanced » Compression Level). |
|
core » jenkins-core #988 SUCCESS |
|
core » jenkins-core #989 SUCCESS |
|
I confirmed that the form confirmation dialog appearing is not related to the changes in this PR... I checked out 70b0c21 and the same thing happens there, so something else is causing that. @daniel-beck I fixed the weirdness on the context menu wrt there being no right padding. The other point re the downarrow is not as straightforward as you might think. That "menuSelector" object is not an <li> element like the other parts of the breadcrumb. Instead, it is an absolute positioned div, only one of which exists for the whole page (everywhere you see that down-arrow... it's the one and same div being used... repositioned via JS and visibility being toggled). We'd have to resize it (to make it the same as the <li> elements) and do other funky stuff, so I think lets leave that one for now. |
|
Adding the padding after the fact leads to a noticeable movement in the breadcrumbs bar when the page finishes loading, and having hierarchical views (nested views or views in folders) will only make it worse. Is there a reason you added a behavior rather than changing the initial element definition itself? (Haven't tried it though) |
|
Doing it in breadcrumbBar.jelly is not enough on it's own (I tried that originally)... other templates contribute links to the breadcrumb. I'll see what we can do. |
|
@daniel-beck movement no more |
|
core » jenkins-core #990 SUCCESS |
|
Awesome! 👍 Can be merged from my POV. |
|
@daniel-beck Thanks for the help, Daniel. |
|
core » jenkins-core #992 SUCCESS |
|
core » jenkins-core #993 SUCCESS |
|
is it meant to look like |
|
@jtnord I'm not sure what device your screenshot is from, but I don't see anything unexpected there. That said, we will be trying to improve the mobile device experience. |
|
@tfennelly device is android jellybean with chrome (sony XPeria SP) The action list, executor list and queue list are all above the job list. |
|
@jtnord This is what it looks like when viewed on a higher res display:
Sorry... I assumed you'd already checked it out on something larger. |
|
@jtnord The switch from side-by-side to what you're seeing is at around 995px wide, which is barely enough to display an essentially empty list view as in the demo. On a test instance I have (with no additional list view columns) I cannot go below 1200px wide without having to scroll sideways. A longer job name, actual builds so it doesn't show |
|
|
||
| #header { | ||
| background-color: #000000; | ||
| height: 50px; |
There was a problem hiding this comment.
I know I'm a little late, but this makes the top bar pretty large, relative to what it's being asked to do (contain the logo and a search bar).
There was a problem hiding this comment.
Hey Kev. Hmmm.... I didn't think it was big, but that's probably just me. I've no prob making it smaller if people think that would be better. I guess we'd need a different/smaller/no icon.
There was a problem hiding this comment.
I think the icon would be ok if it was a tiny bit smaller, and had less
vertical black padding surrounding it
Kevin Burke
phone: 925.271.7005 | kev.inburke.com
On Thu, Jul 10, 2014 at 8:10 AM, Tom Fennelly notifications@github.com
wrote:
In war/src/main/webapp/css/style.css:
body {
margin: 0;
padding: 0;
background: white;
- margin-right: auto;
- margin-left: auto;
+}
+#header {
- background-color: #000000;
- height: 50px;
Hey Kev. Hmmm.... I didn't think it was big, but that's probably just me.
I've no prob making it smaller if people think that would be better. I
guess we'd need a different/smaller/no icon.—
Reply to this email directly or view it on GitHub
https://github.com/jenkinsci/jenkins/pull/1310/files#r14771683.
|
Not sure whether caused by this commit, but the authentication related text is misaligned and almost unreadable on current master: |
|
@daniel-beck Ooops... missed those... will sort out. I thought I did the auth links but obviously un-did it at some point :) Thanks. |
|
If you can get it done today before KK creates the new RC there will only be one Jenkins release this broken ;-) |
|
@daniel-beck "this broken" .... I think there something between the lines there ;) |
|
There's an issue with the Description box when configuring a Job since this PR was merged. Steps to reproduce:
Chrome 35 on OSX |
|
@willdavidwarren That issue has existed for ages, it's trivial to reproduce on 1.532.3 (and 1.571 for that matter). Nothing that was newly introduced here. Just press Please create Jira issues for any further problems (I know I set a bad precedent above, sorry!). |
|
Ooops, my bad - thanks for all your hard work guys! |
|
@tfennelly how hi-res is hi-res? Because on 1280x1024 it's still "vertical". Surely this is not intended? |
|
@burner1024 There's a known issue with IE that can cause this. What browser are you using? Also, if keeping the page on a non-default zoom level, effective resolution is different. 125-140% may be close enough to the point at which it changes to behave like this. |
|
Firefox 30/31 On Thu, Jul 24, 2014 at 12:55 AM, Daniel Beck notifications@github.com
Ilya. |
|
@tfennelly should I open a separate issue for that? |
|
@burner1024 Please do if you haven't already. Use |
|
@tfennelly please have a look at JENKINS-26437, which is about the Translation Assistance Plugin's dialog being partially broken since the first release including this change. |
Another rebase of #1298