Switch underline/non underline on sidebar #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underline adds slightly too much visual weight to the links in question. This changes the links to not have an underline by default, while still adding the underline when the link is hovered. Normally accessibility requirements demand that you add an underline for all clickable text. However, in this case the positioning of the elements, their changed color, the presence of an icon next to the links, and the link hover effect combine to give these elements the appearance of clickability.
|
👍 This is awesome! |
|
core » jenkins-core #1003 SUCCESS |
olivergondza
added a commit
that referenced
this pull request
Jul 10, 2014
Switch underline/non underline on sidebar
|
BTW, the executors list suffers from a similar issue (if you have at least one slave). And the And list views. Wouldn't a lighter link highlight color alone suffice to indicate that something is a link so we could get rid of all the underlines? |
daniel-beck
added a commit
that referenced
this pull request
Jul 12, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underline adds slightly too much visual weight to the links in question.
This changes the links to not have an underline by default, while still adding
the underline when the link is hovered.
Normally accessibility requirements demand that you add an underline for all
clickable text. However, in this case the positioning of the elements, their
changed color, the presence of an icon next to the links, and the link hover
effect combine to give these elements the appearance of clickability.
New state:
On hover: