[JENKINS-24763] Prevent thread starvation in OldDataMonitor by reducing scope of synchronization #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng scope of synchronization
|
@jglick @olivergondza, I reworked this to reduce the scope of synchronization and added a test which reproduces the issue |
| // test will hang here due to JENKINS-24763 | ||
| OldDataMonitor.changeListener | ||
| .onChange(new Saveable() {public void save() throws IOException {}}, | ||
| new XmlFile(File.createTempFile("somexmlfile","xml"))); |
There was a problem hiding this comment.
No indication what program this is from, and no cleanup.
|
LGTM |
|
|
||
| synchronized (this) { | ||
| for (SaveableReference ref : removed) { | ||
| data.remove(ref); |
There was a problem hiding this comment.
data.keySet().removeAll(removed) probably suffices, but not sure.
|
@jglick, if this looks OK, can you merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #1399