Update FindBugs annotation library and maven plugin #1487
Conversation
| @@ -869,7 +869,7 @@ THE SOFTWARE. | |||
| <plugin> | |||
| <groupId>org.codehaus.mojo</groupId> | |||
| <artifactId>findbugs-maven-plugin</artifactId> | |||
| <version>2.5.2</version> | |||
| <version>3.0.0</version> | |||
There was a problem hiding this comment.
Probably want to specify the version just once, in root pom.xml.
There was a problem hiding this comment.
There was a problem hiding this comment.
But you could override that in this PR in (root) pom.xml.
|
annotations-3.0.0.jar created with 1.7.0_51(Oracle Corporation) Can this class be excluded for enforcer check? |
Yes, it could be excluded, since it is using |
|
There is "metrics" profile for findbugs in pom.xml and "findbugs" profile in core/pom.xml |
|
Will back when jenkins migrate on java7 :) |
|
Now with java7 it much easier to do update :) |
|
re-triggerring again, because https://jenkins.ci.cloudbees.com/job/core/job/jenkins-core/2700/testReport/junit/jenkins.security/FilePathSecureTest/tar/ failure unrelated i think. |
|
This got clobbered by your update:
|
|
Other than the duplication, 👍 |
|
@jglick maybe remove reporting at all? Or somebody using it? |
|
maven-site is not updated https://github.com/jenkinsci/maven-site |
|
@jglick set with variable, but can't test because I think nobody uses mvn site and better add build execution for metrics/findbugs profiles. |
|
I do not think |
| @@ -501,7 +501,7 @@ THE SOFTWARE. | |||
| <plugin> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-site-plugin</artifactId> | |||
| <version>3.1</version> | |||
| <version>3.3</version> | |||
There was a problem hiding this comment.
No, either mvn site will fail with absent classes.
There was a problem hiding this comment.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.1:site (default-site) on project pom: Execution default-site of goal org.apache.maven.plugins:maven-site-plugin:3.1:site failed: A required class was missing while executing org.apache.maven.plugins:maven-site-plugin:3.1:site: org/sonatype/aether/graph/DependencyFilter
[ERROR] -----------------------------------------------------
|
👍; is this still supposed to WiP? |
KostyaSha
changed the title
|
@jglick well i not sure that anybody using this reporting at all. I can suggest move findbugs execution from reporting to some build goal. |
|
As update for current versions this PR done. |
|
👍 |
Update FindBugs annotation library and maven plugin
I tried follow version 1.0.0 version and found that it replaced with other library. But it fails because of bytecode. Investigating it, will keep it open here.