[JENKINS-26718] OldDataMonitor: Handle poorly written project types #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @reviewbybees for CloudBees internal review process |
|
|
||
| assertEquals(Collections.singleton(build), odm.getData().keySet()); | ||
| odm.doDiscard(null, null); | ||
| assertEquals(0, odm.getData().keySet().size()); |
There was a problem hiding this comment.
Alternately, a bit nicer in case it ever fails:
assertEquals(Collections.emptySet(), odm.getData().keySet());
|
👍 |
…t be found by its fullname
recampbell
force-pushed
the
JENKINS-26718
branch
from
66854a4
to
327f778
Compare
|
👍 |
|
Seems to work on a test instance, promotions are correctly shown in Manage Old Data, and discarded. |
recampbell
added a commit
that referenced
this pull request
Feb 2, 2015
[JENKINS-26718] OldDataMonitor: Handle poorly written project types
|
@recampbell when merging a fix you need to also update |
Or have the bot do it: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-26718
Allow runs to be discarded even if their project can't be found by its fullname, such as Promotions in promoted builds