Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show « check now » button on PluginManager updates and available pages #1593

Merged
merged 1 commit into from
Mar 3, 2015
Merged

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Mar 3, 2015

No description provided.

@ndeloof
Copy link
Contributor Author

ndeloof commented Mar 3, 2015

@reviewbybees

@stephenc
Copy link
Member

stephenc commented Mar 3, 2015

👍

1 similar comment
@tfennelly
Copy link
Member

👍

ndeloof added a commit that referenced this pull request Mar 3, 2015
show « check now » button on PluginManager updates and available pages
@ndeloof ndeloof merged commit da43ffc into jenkinsci:master Mar 3, 2015
@@ -1,6 +1,5 @@
# This file is under the MIT License by authors

Check\ now=\u041F\u0440\u043E\u0432\u0435\u0440\u0438 \u0441\u0435\u0433\u0430
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW not sure if you found it or not, but core/move-l10n.groovy is the recommended easy way to move bundle keys with localizations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice to know, had to write my own that was ugly.

daniel-beck added a commit that referenced this pull request Mar 12, 2015
@bpedersen2
Copy link
Contributor

it seems that the button does not what it is supposed to todo on the 'plugins update' page.
There are now two buttons with name 'Submit', and so the button really triggers the plugin update, instead of fetch the available updates.

@ndeloof
Copy link
Contributor Author

ndeloof commented Mar 13, 2015

indeed, this creates nested

elements. Need to revisit.

tfennelly added a commit to tfennelly/jenkins that referenced this pull request Mar 16, 2015
* master:
  Updated changelog
  updated changelog as a part of the release
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release jenkins-1.604
  Noting jenkinsci#1597
  Noting jenkinsci#1593, jenkinsci#1579, move JENKINS-22346, jenkinsci#1558
  Remove two fixes that were backported to RC
  JENKINS-27183 Avoid deadlock when using build-monitor-plugin
@jglick
Copy link
Member

jglick commented Mar 16, 2015

Need to revisit.

So is there a confirmed regression? Is it filed? Being fixed?

@daniel-beck
Copy link
Member

Is it filed?

Independently filed as JENKINS-27436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants