[JENKINS-34952] [WiP] Draw item categories #2372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How it should be look like? |
| @@ -1,6 +1,12 @@ | |||
| // Initialize all modules by requiring them. Also makes sure they get bundled (see gulpfile.js). | |||
| var $ = require('jquery-detached').getJQuery(); | |||
|
|
|||
| // Minimum number of item by category to draw the category | |||
| var MIN_ITEM = 6; | |||
There was a problem hiding this comment.
This is a pretty big number IMHO. There are not so many Item types in Jenkins, so would be useful to know reason of such value
|
Generally looks good to me (I've seen the layout at GSoC mid-term presentations) |
oleg-nenashev
added
work-in-progress
|
@oleg-nenashev this is in progress. I hope to finish it this week. |
|
@recena Could you say when you expect to finish this PR? |
|
@samatdav No but I hope soon. |
|
@recena Any plans to finish this? It's been more than 1.5 years. |
|
@recena are you still interested? If no, I propose closing the PR as stalled so that others can pick it up |
oleg-nenashev
added
stalled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-34952
@reviewbybees
@jenkinsci/code-reviewers