Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX JENKINS-41264] Add javadoc workflow explanation #2725

Merged
merged 1 commit into from Feb 12, 2017
Merged

[FIX JENKINS-41264] Add javadoc workflow explanation #2725

merged 1 commit into from Feb 12, 2017

Conversation

varmenise
Copy link
Contributor

No description provided.

@varmenise varmenise added the needs-more-reviews Complex change, which would benefit from more eyes label Jan 23, 2017
@amuniz
Copy link
Member

amuniz commented Jan 30, 2017

👍

@oleg-nenashev
Copy link
Member

Methods should be marked by the "code" tag or by a link annotation. The text itself looks good to me

@daniel-beck
Copy link
Member

@oleg-nenashev Do you require this change?

@oleg-nenashev
Copy link
Member

We do not hurry with the merge right now (weekly is pretty far), so I would rather prefer to see a small fix from @varmenise

@daniel-beck daniel-beck added the needs-comments-resolved Comments in the PR need to be addressed before it can be considered for merging label Feb 1, 2017
@oleg-nenashev
Copy link
Member

I will fix it later since I have an action item to review/update remoting-related Javadocs and annotations

@oleg-nenashev oleg-nenashev added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback and removed needs-comments-resolved Comments in the PR need to be addressed before it can be considered for merging needs-more-reviews Complex change, which would benefit from more eyes labels Feb 12, 2017
@oleg-nenashev
Copy link
Member

@varmenise Please do not dissapear after creating pull requests

@oleg-nenashev oleg-nenashev merged commit ff128f0 into jenkinsci:master Feb 12, 2017
@oleg-nenashev
Copy link
Member

changelogs are not required

@varmenise
Copy link
Contributor Author

varmenise commented Feb 13, 2017 •
edited

@oleg-nenashev I planned to fix it , was in my backlog but I got caught up in higher priorities (unexpected) things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Milestone
No milestone
4 participants
@varmenise @amuniz @oleg-nenashev @daniel-beck