Change rss feed build name #2877
Conversation
With #2845 (released with Jenkins 2.58), if no display name is explicitly set the feed title contains only the build number, which is not very useful for non project specific feeds like the global /rssFailed feed. This commit restores the old behaviour and honours the new behaviour of pull request 2845.
|
This makes no sense to me. Why not always show the project name, via |
|
I just wasn't aware of the |
Changed implementation after receiving feedback to pull request.
|
In code review I misunderstood what #2845 does. Removal of project name would not have been accepted by me, not sure about @oleg-nenashev . |
I missed it as well. |
| @@ -2422,7 +2422,7 @@ public String getEntryID(Run e) { | |||
|
|
|||
| private static class DefaultFeedAdapter implements FeedAdapter<Run> { | |||
| public String getEntryTitle(Run entry) { | |||
| return entry.getDisplayName()+" ("+entry.getBuildStatusSummary().message+")"; | |||
| return entry.getFullDisplayName(); | |||
There was a problem hiding this comment.
So my first commit aec91c4 would be the right choice then?
Or is there a more appropriate/elegant solution?
There was a problem hiding this comment.
your first commit isnt right becouse if default build name changed we will lost project build name in rss feed
| @@ -2422,7 +2422,10 @@ public String getEntryID(Run e) { | |||
|
|
|||
| private static class DefaultFeedAdapter implements FeedAdapter<Run> { | |||
| public String getEntryTitle(Run entry) { | |||
| return entry.getDisplayName()+" ("+entry.getBuildStatusSummary().message+")"; | |||
| if (entry.hasCustomDisplayName()) { | |||
There was a problem hiding this comment.
Project name will lost if custom build name will set
|
Sorry, really didn't realize that I dropped the build status. Thank's for your patience. |
|
#2878 has been integrated both PRs were similar after the fixes in this one. |
|
Thanks @ragaller ! |
Description
With #2845 (released with Jenkins 2.58), if no display name is explicitly set the feed title contains only the build number, which is not very useful for non project specific feeds like the global /rssFailed feed.
This commit restores the old behaviour and honours the new behaviour of pull request 2845.
Proposed changelog entries: