Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a default implementation for SecurityListener #3077

Merged
merged 2 commits into from Oct 21, 2017
Merged

Add a default implementation for SecurityListener #3077

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95ebac9
- add a default implementation doing nothing for the different event …
Wadeck Oct 12, 2017
bafcd78
- remove the useless non-implemented method in this inner class.
Wadeck Oct 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions core/src/main/java/jenkins/security/SecurityListener.java
View file
Open in desktop
Expand Up @@ -50,34 +50,34 @@ public abstract class SecurityListener implements ExtensionPoint {
* Only {@link AbstractPasswordBasedSecurityRealm}s are considered.
* @param details details of the newly authenticated user, such as name and groups
*/
protected abstract void authenticated(@Nonnull UserDetails details);
protected void authenticated(@Nonnull UserDetails details){}

/**
* Fired when a user tried to authenticate by password but failed.
* @param username the user
* @see #authenticated
*/
protected abstract void failedToAuthenticate(@Nonnull String username);
protected void failedToAuthenticate(@Nonnull String username){}

/**
* Fired when a user has logged in via the web UI.
* Would be called after {@link #authenticated}.
* @param username the user
*/
protected abstract void loggedIn(@Nonnull String username);
protected void loggedIn(@Nonnull String username){}

/**
* Fired when a user has failed to log in via the web UI.
* Would be called after {@link #failedToAuthenticate}.
* @param username the user
*/
protected abstract void failedToLogIn(@Nonnull String username);
protected void failedToLogIn(@Nonnull String username){}

/**
* Fired when a user logs out.
* @param username the user
*/
protected abstract void loggedOut(@Nonnull String username);
protected void loggedOut(@Nonnull String username){}

/** @since 1.569 */
public static void fireAuthenticated(@Nonnull UserDetails details) {
Expand Down