Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some PT-BR translations #3102

Merged
merged 2 commits into from Oct 28, 2017
Merged

Add some PT-BR translations #3102

merged 2 commits into from Oct 28, 2017

Conversation

cpanato
Copy link
Contributor

@cpanato cpanato commented Oct 20, 2017

Proposed changelog entries

  • Add some PT-BR translations

@cpanato
Copy link
Contributor Author

cpanato commented Oct 20, 2017

@jenkinsci/hacktoberfest

@daniel-beck
Copy link
Member

@oleg-nenashev Apparently team mentions don't work for people outside the organization.

@daniel-beck
Copy link
Member

@kinow Is this something you could review?

@cpanato
Copy link
Contributor Author

cpanato commented Oct 20, 2017

@cpanato
Copy link
Contributor Author

cpanato commented Oct 20, 2017

@daniel-beck I will add more during next week and so on :)

@daniel-beck
Copy link
Member

@cpanato Thanks, I know, that's why I'm telling Oleg this might not work as expected. I edited your comment so the mention works, but that doesn't scale…

@cpanato
Copy link
Contributor Author

cpanato commented Oct 20, 2017

@daniel-beck looks like the mention trigger did not work as well.
and regarding the build, I saw all steps were green, what is the issue?

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translating from English to Portuguese is really tricky. Found a few minor typos, and some sentences that could be re-written to sound more natural. Though that's still a bit subjective.

@boaglio might be able to help too. He has experience with i18n on KDE, and did most of the pt_BR for Jenkins.

# {0} v{1} is missing. To fix, install v{1} or later.
PluginWrapper.missing={0} v{1} est\u00E1 faltando. Para corrigir, instale v{1} ou superior.
# No Exception details
Functions.NoExceptionDetails=Sem detalhes da exce\u00E7\u00E3o
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exception is normally left untranslated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -76,3 +76,38 @@ ProxyConfiguration.FailedToConnect=Falha ao conectar em {0} (c\u00f3digo {1}).
ProxyConfiguration.Success=Sucesso
# Did not manage to validate {0} (may be too slow)
FilePath.did_not_manage_to_validate_may_be_too_sl=N\u00e3o conseguiu validar {0} (pode ser muito lento)
# {0} v{1} is missing. To fix, install v{1} or later.
PluginWrapper.missing={0} v{1} est\u00E1 faltando. Para corrigir, instale v{1} ou superior.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like "Não foi possível encontrar {0} v{1}" would sound better

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

# Plugins Failed To Load
PluginWrapper.PluginWrapperAdministrativeMonitor.DisplayName=Falha ao carregar o plugin
# Malformed Test URL {0}.
ProxyConfiguration.MalformedTestUrl=URL de test mal formatada {0}.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case it is better to translate test to "teste". But something like "URL de teste inválida" would probably sound better

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Functions.NoExceptionDetails=Sem detalhes da exce\u00E7\u00E3o
# \
# Whitespace can no longer be used as the separator. Please Use \u2018,\u2019 as the separator instead.
FilePath.validateAntFileMask.whitespaceSeparator=Espa\u00E7o em branco n\u00E3o podem mais serrem utilizados como separador. Por favor use \u2018, \u2019 como separadores.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lack of concordance here. It should be in the plural, "Espa\u00E7os".

There is also a typo, as instead of "serrem", it has to be "serem"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

# Whitespace can no longer be used as the separator. Please Use \u2018,\u2019 as the separator instead.
FilePath.validateAntFileMask.whitespaceSeparator=Espa\u00E7o em branco n\u00E3o podem mais serrem utilizados como separador. Por favor use \u2018, \u2019 como separadores.
# Ping protocol
TcpSlaveAgentListener.PingAgentProtocol.displayName=Protocolo de ping
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one sounds a bit odd in Portuguese, but I can't think of a better way. Probably because I never heard it, but should be OK

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will leave as is, or we can keep the original

@@ -26,3 +26,4 @@ Configure=Configurar
Status=Situa\u00e7\u00e3o
Load\ Statistics=Estat\u00edsticas de carga
Script\ Console=Terminal de script
Delete\ Agent=Apagar o agente
Copy link
Member

@kinow kinow Oct 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Remover" would be better IMO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -25,3 +25,5 @@ name=Nome do {0}
Description=Descri\u00e7\u00e3o
Save=Salvar
LOADING=CARREGANDO
# Apply
Apply=Aplicar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an interesting one. In other systems I normally see "Concluir", but I guess in other parts we are probably using Aplicar. So +1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok :)

@@ -33,3 +33,4 @@ Downstream\ Builds=builds filho
none=nenhum
Took=Demorou
Build=Build
on=ativo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case this translation would be incorrect. Here's where it is used: https://github.com/cpanato/jenkins/blob/2f11dc2fea19c65b0b9a399531ddf775bbe2e55a/core/src/main/resources/hudson/model/AbstractBuild/index.jelly#L45

The "on" is used in a sentence like "Took 10ms on ...."

Probably "em" would be a better translation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

# \u2018{0}\u2019 doesn\u2019t match anything: even \u2018{1}\u2019 doesn\u2019t exist
FilePath.validateAntFileMask.doesntMatchAnythingAndSuggest=\u2018{0}\u2019 n\u00E3o combina nada: o \u2018{1}\u2019 n\u00E3o existe
# {0} v{1} failed to load. Fix this plugin first.
PluginWrapper.failed_to_load_dependency={0} v{1} falhou ao carregar. Primeiro corrija este plugin.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Primeiro corrija este plugin." would be better re-worded as "Corrija o problema com este plugin primeiro" IMO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

# You must update Jenkins from v{0} to v{1} or later to run this plugin.
PluginWrapper.obsoleteCore=Voc\u00EA deve atualizar o Jenkins de v{0} para v{1} ou superior para executar este plugin.
# \u2018{0}\u2019 doesn\u2019t match anything: even \u2018{1}\u2019 doesn\u2019t exist
FilePath.validateAntFileMask.doesntMatchAnythingAndSuggest=\u2018{0}\u2019 n\u00E3o combina nada: o \u2018{1}\u2019 n\u00E3o existe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra white spaces, but also the "combina" sounds a bit weird. It is used in the context that a ant file mask, a kind of glob, didn't find any matching entry. So probably "(...) não retornou nenhum resultado: nem mesmo ... existe"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@oleg-nenashev oleg-nenashev added the hacktoberfest Related to Hacktoberfest. https://hacktoberfest.digitalocean.com/ label Oct 21, 2017
@cpanato
Copy link
Contributor Author

cpanato commented Oct 21, 2017

@kinow thanks for your review so much! I've pushed the fixes.

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit pick. Other than that, looking good for me.

# {0} v{1} is older than required. To fix, install v{2} or later.
PluginWrapper.obsolete={0} v{1} \u00E9 mais antigo do que o requerido. Para corrigir, instale v{2} ou superior.
# \u2018{0}\u2019 doesn\u2019t match anything because it is treated case sensitively. You can deactivate case sensitivity to get matches
FilePath.validateAntFileMask.matchWithCaseInsensitive=
# You must update Jenkins from v{0} to v{1} or later to run this plugin.
PluginWrapper.obsoleteCore=Voc\u00EA deve atualizar o Jenkins de v{0} para v{1} ou superior para executar este plugin.
# \u2018{0}\u2019 doesn\u2019t match anything: even \u2018{1}\u2019 doesn\u2019t exist
FilePath.validateAntFileMask.doesntMatchAnythingAndSuggest=\u2018{0}\u2019 n\u00E3o combina nada: o \u2018{1}\u2019 n\u00E3o existe
FilePath.validateAntFileMask.doesntMatchAnythingAndSuggest=\u2018{0}\u2019 n\u00E3o retornou nenhum resultado: nem mesmo \u2018{1}\u2019 existe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still an extra space here"nem mesmo \u2018{1}\u2019 existe" after "mesmo".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -21,3 +21,6 @@
# THE SOFTWARE.

Changes=Mudan\u00e7as
Not\ yet\ determined=
Failed\ to\ determine=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty values

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issues in property file formatting, etc. Have not tested the content though

@oleg-nenashev
Copy link
Member

@daniel-beck PTAL

@boaglio
Copy link
Contributor

boaglio commented Oct 27, 2017

thanks @kinow and @cpanato for this =D

Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No empty keys anymore AFAICT, so 🤷‍♂️

@oleg-nenashev forced me to do this.

@oleg-nenashev oleg-nenashev merged commit 1b4f875 into jenkinsci:master Oct 28, 2017
@oleg-nenashev
Copy link
Member

@cpanato thanks!

@cpanato cpanato deleted the translate-pt-br branch October 29, 2017 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Related to Hacktoberfest. https://hacktoberfest.digitalocean.com/
Projects
None yet
5 participants