Correction of quote for French + space before colon #3179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wadeck
added
the
needs-more-reviews
alecharp
suggested changes
Dec 8, 2017
| @@ -26,7 +26,7 @@ CopyExisting=Copier un {0} existant | |||
| ItemName.help=Champ obligatoire | |||
| ItemName.label=Saisissez un nom | |||
| ItemName.validation.required=Ce champ ne peut pas \u00eatre vide. Veuillez saisir un nom valide et appuyer sur OK. | |||
| ItemType.validation.required=Veuillez choisir un type d\'Item | |||
| ItemType.validation.required=Veuillez choisir un type d\u2019Item | |||
There was a problem hiding this comment.
maybe we can translate "Item" as well
Wadeck
added
ready-for-merge
|
@reviewbybees done |
|
Hmm, it impacts other translations as well. |
oleg-nenashev
added
the
on-hold
|
As I see the colon has been moved from template to translations so it should not have impact for translations that were updated (hopefully all). So for Polish translation - fix is fine. |
|
@damianszczepanik yeah all the translations where I can read the characters that have a colon were updated (and CC in the description) |
damianszczepanik
approved these changes
Jan 3, 2018
oleg-nenashev
removed
the
on-hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\'in french:, in english only one space after, in french one before and one afterAs the colon moved from HTML to translation (properties file), I let original translator validates the addition of colon in their language.
@reviewbybees