New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of quote for French + space before colon #3179

Merged
merged 2 commits into from Jan 6, 2018

Conversation

4 participants
@Wadeck
Contributor

Wadeck commented Dec 8, 2017

  • correction of a \' in french
  • add a space before :, in english only one space after, in french one before and one after

As the colon moved from HTML to translation (properties file), I let original translator validates the addition of colon in their language.

@reviewbybees

@Wadeck Wadeck added the needs-review label Dec 8, 2017

@Wadeck Wadeck requested a review from alecharp Dec 8, 2017

@@ -26,7 +26,7 @@ CopyExisting=Copier un {0} existant
ItemName.help=Champ obligatoire
ItemName.label=Saisissez un nom
ItemName.validation.required=Ce champ ne peut pas \u00eatre vide. Veuillez saisir un nom valide et appuyer sur OK.
ItemType.validation.required=Veuillez choisir un type d\'Item
ItemType.validation.required=Veuillez choisir un type d\u2019Item

This comment has been minimized.

@alecharp

alecharp Dec 8, 2017

Member

maybe we can translate "Item" as well

@Wadeck Wadeck requested a review from alecharp Dec 11, 2017

@alecharp

LGTM 🐝

@Wadeck Wadeck added ready-for-merge and removed needs-review labels Jan 2, 2018

@Wadeck

This comment has been minimized.

Contributor

Wadeck commented Jan 2, 2018

@oleg-nenashev

This comment has been minimized.

Member

oleg-nenashev commented Jan 2, 2018

Hmm, it impacts other translations as well.
Let's wait for responses from CCed translation contributors

@damianszczepanik

This comment has been minimized.

Contributor

damianszczepanik commented Jan 3, 2018

As I see the colon has been moved from template to translations so it should not have impact for translations that were updated (hopefully all). So for Polish translation - fix is fine.

@Wadeck

This comment has been minimized.

Contributor

Wadeck commented Jan 3, 2018

@damianszczepanik yeah all the translations where I can read the characters that have a colon were updated (and CC in the description)
Thank you for the review 👍

@oleg-nenashev oleg-nenashev removed the on-hold label Jan 6, 2018

@oleg-nenashev oleg-nenashev merged commit 93bf063 into jenkinsci:master Jan 6, 2018

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment