Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-34254] Fix 'crumb missing' form #3186

Closed
wants to merge 2 commits into from

Conversation

daniel-beck
Copy link
Member

See JENKINS-34254.

This is currently just a rebased #2268.

Jenkins currently breaks in this way and makes some built-in features plain unusable with enabled CSRF protection (which is the default since 2.0, ~19 months ago, and nobody should be disabling this anyway!).

Proposed changelog entries

  • Make the 'Retry with POST' form work when CSRF protection is enabled.

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

@daniel-beck daniel-beck added the work-in-progress The PR is under active development, not ready to the final review label Dec 9, 2017
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3187 looks better to me.

@daniel-beck daniel-beck added the on-hold This pull request depends on another event/release, and it cannot be merged right now label Dec 11, 2017
@daniel-beck
Copy link
Member Author

Closing in favor of #3187.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-hold This pull request depends on another event/release, and it cannot be merged right now work-in-progress The PR is under active development, not ready to the final review
Projects
None yet
3 participants