Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-48505] - Invoke optimistic get before computeIfAbsent to avoid contention. #3198

Merged
merged 1 commit into from Dec 16, 2017
Merged

[JENKINS-48505] - Invoke optimistic get before computeIfAbsent to avoid contention. #3198

merged 1 commit into from Dec 16, 2017

Conversation

johnou
Copy link
Member

@johnou johnou commented Dec 15, 2017 •
edited

See JENKINS-48505 and discussion about performance concerns wrt computeIfAbsent #3091

Proposed changelog entries

Invoke optimistic get before computeIfAbsent to avoid contention with ExtensionList.

Desired reviewers

@oleg-nenashev
@jglick

@johnou johnou mentioned this pull request Dec 15, 2017
Merged
@oleg-nenashev oleg-nenashev changed the title Invoke optimistic get before computeIfAbsent to avoid contention. [JENKINS-48505] - Invoke optimistic get before computeIfAbsent to avoid contention. Dec 15, 2017
@oleg-nenashev oleg-nenashev added needs-more-reviews Complex change, which would benefit from more eyes regression-fix Pull request that fixes a regression in one of the previous Jenkins releases labels Dec 15, 2017
@oleg-nenashev
Copy link
Member

@jenkinsci/code-reviewers

jglick
jglick approved these changes Dec 15, 2017
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I attempted to update the JIRA issue to reflect the assignee and status of this; please double-check.

@oleg-nenashev oleg-nenashev added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback and removed needs-more-reviews Complex change, which would benefit from more eyes labels Dec 16, 2017
@oleg-nenashev oleg-nenashev merged commit 3a52963 into jenkinsci:master Dec 16, 2017
@johnou johnou deleted the contention-JENKINS-48505 branch December 16, 2017 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases
Projects
None yet
Milestone
No milestone
3 participants
@johnou @oleg-nenashev @jglick