New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ToolDescriptor constructor so subclasses are not required to be an inner class #3220

Merged
merged 2 commits into from Jan 10, 2018

Conversation

4 participants
@dwnusbaum
Member

dwnusbaum commented Jan 8, 2018

Allow subclasses of ToolDescriptor to use the Descriptor(Class<T>) constructor so that subclasses do not have to be an inner class of their Describable. Required to split out JDK$DescriptorImpl as part of JENKINS-22367, see #3147.

I am happy to create a JIRA ticket or tests if desired.

Proposed changelog entries

  • Developer: Add a constructor to ToolDescriptor so that subclasses are not required to be an inner class of their Describable

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@reviewbybees

@dwnusbaum dwnusbaum requested a review from jglick Jan 8, 2018

@jglick

jglick approved these changes Jan 8, 2018

super();
}
protected ToolDescriptor(Class<T> clazz) {

This comment has been minimized.

@jglick

jglick Jan 8, 2018

Member

add

/**
 * @since FIXME
 */

This comment has been minimized.

@jglick

jglick Jan 10, 2018

Member

(resolved)

@@ -54,6 +54,14 @@
private T[] installations;
protected ToolDescriptor() {
super();

This comment has been minimized.

@jglick

jglick Jan 8, 2018

Member

Or can just be omitted:

protected ToolDescriptor() {}

@dwnusbaum dwnusbaum requested review from jglick and daniel-beck Jan 8, 2018

@oleg-nenashev

🐝

@dwnusbaum

This comment has been minimized.

Member

dwnusbaum commented Jan 9, 2018

@jglick

jglick approved these changes Jan 10, 2018

super();
}
protected ToolDescriptor(Class<T> clazz) {

This comment has been minimized.

@jglick

jglick Jan 10, 2018

Member

(resolved)

@jglick jglick merged commit deeab3a into jenkinsci:master Jan 10, 2018

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details

@dwnusbaum dwnusbaum deleted the dwnusbaum:tooldescriptor-constructor branch Jan 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment