Add new ToolDescriptor constructor so subclasses are not required to be an inner class #3220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arate file from their describable
jglick
approved these changes
Jan 8, 2018
| super(); | ||
| } | ||
|
|
||
| protected ToolDescriptor(Class<T> clazz) { |
| @@ -54,6 +54,14 @@ | |||
|
|
|||
| private T[] installations; | |||
|
|
|||
| protected ToolDescriptor() { | |||
| super(); | |||
There was a problem hiding this comment.
Or can just be omitted:
protected ToolDescriptor() {}
daniel-beck
approved these changes
Jan 9, 2018
oleg-nenashev
added
the
ready-for-merge
|
@reviewbybees done |
jglick
approved these changes
Jan 10, 2018
| super(); | ||
| } | ||
|
|
||
| protected ToolDescriptor(Class<T> clazz) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow subclasses of
ToolDescriptorto use theDescriptor(Class<T>)constructor so that subclasses do not have to be an inner class of theirDescribable. Required to split outJDK$DescriptorImplas part of JENKINS-22367, see #3147.I am happy to create a JIRA ticket or tests if desired.
Proposed changelog entries
ToolDescriptorso that subclasses are not required to be an inner class of theirDescribableSubmitter checklist
* Use the
Internal:prefix if the change has no user-visible impact (API, test frameworks, etc.)Desired reviewers
@reviewbybees